maui icon indicating copy to clipboard operation
maui copied to clipboard

Removes dead code from type conversion

Open vitek-karas opened this issue 1 year ago • 3 comments

Description of Change

The removed code would only run if converter was not null. But in that case the if on line 166 would match and it would return from the method. So the removed code can only be reached if converter is null.

vitek-karas avatar Dec 15 '23 10:12 vitek-karas

Hey there @vitek-karas! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

ghost avatar Dec 15 '23 10:12 ghost

/azp run

PureWeen avatar Dec 15 '23 18:12 PureWeen

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Dec 15 '23 18:12 azure-pipelines[bot]

I wonder if it is better to still remove this dead code, then rather wrap the try in an if instead of the type convert? Makes it more readable and removes an unnecesary cast.

mattleibow avatar Jan 19 '24 08:01 mattleibow

I believe this code was there to handle System.ComponentModel.TypeConverter in addition of XF TypeConverter, but we a quick check indicates we got rid of that

StephaneDelcroix avatar Jan 19 '24 08:01 StephaneDelcroix

/azp run

jsuarezruiz avatar Jan 26 '24 12:01 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jan 26 '24 12:01 azure-pipelines[bot]