maui
maui copied to clipboard
Removes dead code from type conversion
Description of Change
The removed code would only run if converter
was not null. But in that case the if on line 166 would match and it would return from the method. So the removed code can only be reached if converter
is null.
Hey there @vitek-karas! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.
/azp run
Azure Pipelines successfully started running 3 pipeline(s).
I wonder if it is better to still remove this dead code, then rather wrap the try in an if instead of the type convert? Makes it more readable and removes an unnecesary cast.
I believe this code was there to handle System.ComponentModel.TypeConverter in addition of XF TypeConverter, but we a quick check indicates we got rid of that
/azp run
Azure Pipelines successfully started running 3 pipeline(s).