maui
maui copied to clipboard
dotnet
[Android] Fix Button Ripple Effect not working
Description of Change
Fix Button Ripple Effect not working using a custom background. An incorrect result is obtained under some conditions using Border Drawable in composition with RippleDrawable in addition to increasing the complexity when creating the Button background Drawable. For that reason, added directly the ripple effect support to BorderDrawable.
Issues Fixed
Fixes #17642 Fixes #18815
@jsuarezruiz Is this the planned fix for https://github.com/dotnet/maui/issues/18815 as well?
Hi @jsuarezruiz. We have added the "s/pr-needs-author-input" label to this issue, which indicates that we have an open question/action for you before we can take further action. This PRwill be closed automatically in 14 days if we do not hear back from you by then - please feel free to re-open it if you come back to this PR after that time.
So this will just be closed? How can it be, that throughout a whole major version of .NET, button animations (so almost everything that's being tapped) just don't work for one of the biggest platforms of .NET MAUI (Android), and Microsoft doesn't seem to care about it. I was really looking forward to migrate from Xamarin to .NET MAUI, but with this issue the app just looks plain unprofessional and cannot be delivered to any customers as it is.
So this will just be closed? How can it be, that throughout a whole major version of .NET, button animations (so almost everything that's being tapped) just don't work for one of the biggest platforms of .NET MAUI (Android), and Microsoft doesn't seem to care about it. I was really looking forward to migrate from Xamarin to .NET MAUI, but with this issue the app just looks plain unprofessional and cannot be delivered to any customers as it is.
Reopened and is a priority for the next release.
Reopened and is a priority for the next release.
That is really, really good to hear. Just to clarify: "Next release" as in ".NET 9" or as in ".NET 8 SR1/2"? 🤔