maui
maui copied to clipboard
dotnet
Reinstate animated GIF on iOS & macOS
Description of Change
Reinstates the functionality to show animated GIFs on iOS and macOS
Issues Fixed
Fixes #866
People who are interested in this PR, might also like: #14295
If you decide within 10 minutes, you'll get 2 working animated GIF platforms at the price of 1!
@mattleibow I'm not sure I understand. From a quick glance at the links I think that is what we're doing with this code? It seems to be different implementations but it mostly comes down to the same stuff from what I can tell. I agree that this should be easier and built-in to iOS, but alas 😅
If you think there is an easier/better way to do this let me know! Else, maybe we can merge this as is and open an issue to track an future potential improvement?
You are, but then you are also adding a new animation layer to the UIImageView - that control already has a property to do animations: https://developer.apple.com/documentation/uikit/uiimageview/1621068-animationimages
Is it possible to use that instead?
Hello, I'm very interested in this feature, @jfversluis can you provide us an estimated date of PR Completion ?
I agree that using https://developer.apple.com/documentation/uikit/uiimageview/1621068-animationimages can simplify the code, but with those changes it would not reach the .NET 8 GA at time, right? Would it then be more interesting to have gifs working with the same Xamarin.Forms code and refactor, improving for .NET 9? (opening a new request)
@mattleibow @jsuarezruiz I think I did (a bit of) both! The code is a bit clear, no extra layer and I think I actually fixed a bug that was in there since Forms that would make the animation go super fast or super slow.
What do you think?
@jpd21122012 I'm hoping to get this in for .NET 8 asap, but no guarantees 😄
