maui icon indicating copy to clipboard operation
maui copied to clipboard

Published 20 hours ago • verified publisher icon dotnet

[iOS] Fix gestures in Label Spans

Open jsuarezruiz opened this issue 1 year ago • 21 comments

Description of Change

Fix gestures in Label Spans on iOS.

To test/validate the changes, open the .NET MAUI Gallery and navigate to the Label page. Tap the Span with the text "Click Me". If the Span changes the TextColor, is working as expected.

Also tested using the Issue3525 UI Test.

Issues Fixed

Fixes https://github.com/dotnet/maui/issues/8004 Fixes https://github.com/dotnet/maui/issues/4734

jsuarezruiz avatar Jun 09 '23 10:06 jsuarezruiz

Is there a reason this is still in draft @jsuarezruiz?

mattleibow avatar Jun 29 '23 15:06 mattleibow

/rebase

mattleibow avatar Jun 29 '23 15:06 mattleibow

Is there a reason this is still in draft @jsuarezruiz?

Yes, sorry. All my open PRs, are Draft except 4 to focus on them, speed up merges and reduce the number of open PRs (20 at the moment).

jsuarezruiz avatar Jun 30 '23 07:06 jsuarezruiz

Added UI Test.

jsuarezruiz avatar Aug 17 '23 10:08 jsuarezruiz

Tests are failing?

samhouts avatar Sep 11 '23 23:09 samhouts

Hi @jsuarezruiz. We have added the "s/pr-needs-author-input" label to this issue, which indicates that we have an open question/action for you before we can take further action. This PRwill be closed automatically in 14 days if we do not hear back from you by then - please feel free to re-open it if you come back to this PR after that time.

ghost avatar Sep 11 '23 23:09 ghost

Test passing on device and simulators: image

jsuarezruiz avatar Oct 06 '23 09:10 jsuarezruiz

Hi @jsuarezruiz. We have added the "s/pr-needs-author-input" label to this issue, which indicates that we have an open question/action for you before we can take further action. This PRwill be closed automatically in 14 days if we do not hear back from you by then - please feel free to re-open it if you come back to this PR after that time.

ghost avatar Oct 16 '23 16:10 ghost

@jsuarezruiz will this fix make it into .net 8 with the android fix?

IeuanWalker avatar Nov 03 '23 13:11 IeuanWalker

@IeuanWalker It is slated for .NET MAUI 8 Service Release 2. See above:

image

MartyIX avatar Nov 03 '23 14:11 MartyIX

@jsuarezruiz will this fix make it into .net 8 with the Android fix?

You can introduce the new label control view and copy the fix implementation of ArrangeOverride as a temporary fix for iOS; this is what I plan to do :)

artemvalieiev avatar Nov 06 '23 19:11 artemvalieiev

Will this PR be re-opened? This is sorely needed as it breaks apps migrating from Xamarin which used this feature.

rjhind avatar Nov 21 '23 07:11 rjhind

@jsuarezruiz @PureWeen @samhouts 👆👀

IeuanWalker avatar Nov 24 '23 16:11 IeuanWalker

/rebase

mattleibow avatar Dec 12 '23 11:12 mattleibow

Let's see how this goes with the rebase on top of all our CI fixes.

mattleibow avatar Dec 12 '23 11:12 mattleibow

I hope this iOS fix for label spans happens soon....

RedZone908 avatar Jan 12 '24 22:01 RedZone908

I know this is marked stale but it's definitely still an issue that needs to be fixed on iOS for .NET 8.

RedZone908 avatar Jan 12 '24 22:01 RedZone908

Does anyone know of a workaround for this until this PR makes it's way through?

BrandanN21 avatar Jan 16 '24 20:01 BrandanN21

@BrandanN21 https://github.com/dotnet/maui/issues/4734#issuecomment-1891172645

IeuanWalker avatar Jan 16 '24 21:01 IeuanWalker

Agreeing with above commenters, this update would be great to have added in for service release 2, as mentioned above. Any updates on status?

JCzubkowskiTrek avatar Jan 16 '24 21:01 JCzubkowskiTrek

Removed the stale label, build is passing.

jsuarezruiz avatar Jan 25 '24 11:01 jsuarezruiz

iOS update Android update

tj-devel709 avatar Feb 07 '24 14:02 tj-devel709

Waiting for the iOS UITests to work again!

tj-devel709 avatar Feb 08 '24 15:02 tj-devel709

/rebase

PureWeen avatar Feb 14 '24 20:02 PureWeen

Can someone confirm that this is fixed for Windows too, please?

jameslavery avatar Feb 15 '24 07:02 jameslavery

yep, I desperately need this for windows too

sjorsmiltenburg avatar Feb 15 '24 08:02 sjorsmiltenburg

What version of .NET MAUI will this fix appear in? We have users complaining they can't tap links on iOS and we'd like to be able to give an ETA on the fix.

thanks

RobTF avatar Mar 04 '24 12:03 RobTF

Can someone confirm that this is fixed for Windows too, please?

You can try a nightly build (https://github.com/dotnet/maui/wiki/Nightly-Builds) to verify if the PR fixes your issue.

MartyIX avatar Mar 04 '24 12:03 MartyIX

What version of .NET MAUI will this fix appear in? We have users complaining they can't tap links on iOS and we'd like to be able to give an ETA on the fix.

thanks

Not a MAUI team member but https://github.com/orgs/dotnet/projects/194/views/22?pane=issue&itemId=15608832 shows that it should be released as a part of the SR3 release. So hopefully at most weeks. No guarantees.

MartyIX avatar Mar 04 '24 13:03 MartyIX

Thanks @MartyIX. We wouldn't generally play with the nightly builds as we can't use them in production anyway, so we're interested in getting a version/date of when the fix is officially released but thanks or the idea and looking into it for me. I struggled to find that page.

RobTF avatar Mar 04 '24 13:03 RobTF