maui icon indicating copy to clipboard operation
maui copied to clipboard

Fix Label Multilinetruncation (MaxLines / LineBreakMode)

Open jsuarezruiz opened this issue 2 years ago • 8 comments
trafficstars

Description of Change

Android iOS Windows
issue-13981-droid ios issue-13981-win

Summary:

  • The Button does not have the MaxLines property, it always stays with a single line and doing the tail truncation.
  • With a Label, if the maximum number of lines is not specified, when establishing the LineBreakMode.TailTruncation the maximum number of lines used is 1, and tail truncation is applied.
  • If MaxLines and LineBreakMode are established in the Label, both options are applied.

Issues Fixed

Fixes #14125

jsuarezruiz avatar May 04 '23 08:05 jsuarezruiz

Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines.

github-actions[bot] avatar May 04 '23 08:05 github-actions[bot]

Are there any tests we can add for these changes?

Sure. image

jsuarezruiz avatar May 08 '23 10:05 jsuarezruiz

One little step closer... Please someone who can merge it... 🙏

EmanterolaDN avatar May 11 '23 14:05 EmanterolaDN

Tests are failing?

samhouts avatar Sep 11 '23 23:09 samhouts

Hi @jsuarezruiz. We have added the "s/pr-needs-author-input" label to this issue, which indicates that we have an open question/action for you before we can take further action. This PRwill be closed automatically in 14 days if we do not hear back from you by then - please feel free to re-open it if you come back to this PR after that time.

ghost avatar Oct 16 '23 16:10 ghost

Please test changes against https://github.com/dotnet/maui/issues/18059, too. Thanks!

samhouts avatar Oct 16 '23 16:10 samhouts

Please test changes against #18059, too. Thanks!

Added a specific device test to validate that case.

jsuarezruiz avatar Nov 14 '23 11:11 jsuarezruiz

Is it possible to include this PR in the next Servicing Release?

hansmbakker avatar Dec 07 '23 11:12 hansmbakker

/rebase

mattleibow avatar Jan 17 '24 23:01 mattleibow

/rebase

mattleibow avatar Jan 18 '24 00:01 mattleibow

/rebase

mattleibow avatar Jan 18 '24 00:01 mattleibow