maui
maui copied to clipboard
dotnet
[RadioButton] Fix Issue with BorderWidth, Incorrect spacing in Default Control Template.
Description of Change
This adapts a previously submitted PR that was closed before it was reviewed: https://github.com/dotnet/maui/pull/8292 The underlying Frame was changed to a Border to support BorderWidth attribute not working.
An addition of column spacing to the underlying grid fixes the ellipse being too close to the content text, and additional padding of the grid prevents it from clipping.
| Before | After |
|---|---|
 |
 |
| Before | After |
|---|---|
 |
 |
Question that arose: According to docs for RadioButton, CornerRadius is set to be an integer: CornerRadius however, Corner Radius use double values: Corner Radius Constructor. Should I change the API to reflect this?
Issues Fixed
Fixes #8291
Thank you for your pull request. We are auto-formating your source code to follow our code guidelines.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thank you for your pull request. We are auto-formating your source code to follow our code guidelines.
@dustin-wojciechowski
According to docs for RadioButton, CornerRadius is set to be an integer: CornerRadius however, Corner Radius use double values: Corner Radius Constructor. Should I change the API to reflect this?
We looked at doing this when we went over to MAUI and determined that it didn't add enough value given that it would be a breaking change.
