maui icon indicating copy to clipboard operation
maui copied to clipboard

Fix syncing modal stack when the window is created/recreated

Open PureWeen opened this issue 2 years ago • 2 comments

Description of Change

Fix ModalNavigationManager so it will reprocess the current Modal stack when the root window handler changes. Currently we aren't processing any modal pages pushed before the app has loaded and we don't reprocess the modal stack if the window is destroyed and recreated (Android).

This PR adds code to detect when we need to reprocess the modal stack based on the root view changing or being destroyed

Breaking Changes

  • On Window if a lifecycle event is called at a place in time that doesn't make sense, we will now throw an exception. https://github.com/dotnet/maui/pull/13025/files#diff-07d5a2c0b5069d448623e88d890e41bc2c21e12f99bd01f1349903a332d4130cR475-R519

Issues Fixed

Fixes #8157

PureWeen avatar Jan 31 '23 17:01 PureWeen

:warning: Your code has been reformatted. :warning:

github-actions[bot] avatar Feb 13 '23 21:02 github-actions[bot]

🚨 Breaking change detected @davidbritch FYI

ghost avatar Feb 23 '23 22:02 ghost

/azp run

PureWeen avatar Mar 14 '23 01:03 PureWeen

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Mar 14 '23 01:03 azure-pipelines[bot]

Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines.

github-actions[bot] avatar Mar 15 '23 19:03 github-actions[bot]