maui icon indicating copy to clipboard operation
maui copied to clipboard

Fix Flyout and TitleView Offset Measurements

Open PureWeen opened this issue 3 years ago • 4 comments

Description of Change

Rework the Shell Flyout Templates/TitleView to mesh with .NET MAUI layout rules. The measuring and arranging of the templates needed to adjust for how margins are applied with the new layout system. This PR also streamlines the measuring/arranging so it's more part of the lifecycle instead of just randomly calling "remeasure" at different points in time hoping you'll eventually end up with things measured correctly.

This also decouples the Margin property from the SafeArea. Instead of applying the safe area to the margin we just apply the safe area to the container views if the user hasn't indicated they want to control the margins.

TitleView and Flyout Templates use the same platform containers which is why this PR addresses both.

Issues Fixed

Fixes #11679

PureWeen avatar Jan 06 '23 19:01 PureWeen

Thank you for your pull request. We are auto-formating your source code to follow our code guidelines.

github-actions[bot] avatar Feb 17 '23 23:02 github-actions[bot]

Thank you for your pull request. We are auto-formating your source code to follow our code guidelines.

github-actions[bot] avatar Feb 17 '23 23:02 github-actions[bot]

Thank you for your pull request. We are auto-formating your source code to follow our code guidelines.

github-actions[bot] avatar Feb 19 '23 00:02 github-actions[bot]

I saw things with parallax and toolbars and titles and things, so is it potentially related to: https://github.com/dotnet/maui/issues/9053

mattleibow avatar Mar 10 '23 16:03 mattleibow

/azp run

PureWeen avatar Mar 14 '23 02:03 PureWeen

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Mar 14 '23 02:03 azure-pipelines[bot]