maui Allow CommunityToolkit to avoid reflection to access the CollectionView controller

Allow CommunityToolkit to avoid reflection to access the CollectionView controller

Open VladislavAntonyuk opened this issue 2 years ago • 5 comments

Update protected to internal

Fixes https://github.com/CommunityToolkit/Maui/pull/751

Dec 21 '22 18:12 VladislavAntonyuk

Hey there @VladislavAntonyuk! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Dec 21 '22 18:12 ghost

Shouldn't this be protected internal

https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/keywords/protected-internal

Dec 21 '22 19:12 inforithmics

Specifically, this PR allows us to avoid needing to implement this specific use of reflection to fix a bug around Expander + CollectionView

Dec 21 '22 19:12 brminnick

/azp run

Dec 22 '22 07:12 jfversluis

Azure Pipelines successfully started running 2 pipeline(s).

Dec 22 '22 07:12 azure-pipelines[bot]

Hi all, Thank you for your support! In which version of .NET 7 will this PR be published? Do you have an idea when? Regards, Damiano

Jan 09 '23 08:01 curia-damiano

/backport to net7.0

Jan 12 '23 15:01 PureWeen

Started backporting to net7.0: https://github.com/dotnet/maui/actions/runs/3903839609

Jan 12 '23 15:01 github-actions[bot]