maui icon indicating copy to clipboard operation
maui copied to clipboard

Published 20 hours ago • verified publisher icon dotnet

Allow CommunityToolkit to avoid reflection to access the CollectionView controller

Open VladislavAntonyuk opened this issue 1 year ago • 5 comments

Description of Change

Update protected to internal

Issues Fixed

Fixes https://github.com/CommunityToolkit/Maui/pull/751

VladislavAntonyuk avatar Dec 21 '22 18:12 VladislavAntonyuk

Hey there @VladislavAntonyuk! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

ghost avatar Dec 21 '22 18:12 ghost

Shouldn't this be protected internal

https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/keywords/protected-internal

inforithmics avatar Dec 21 '22 19:12 inforithmics

Specifically, this PR allows us to avoid needing to implement this specific use of reflection to fix a bug around Expander + CollectionView

brminnick avatar Dec 21 '22 19:12 brminnick

/azp run

jfversluis avatar Dec 22 '22 07:12 jfversluis

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Dec 22 '22 07:12 azure-pipelines[bot]

Hi all, Thank you for your support! In which version of .NET 7 will this PR be published? Do you have an idea when? Regards, Damiano

curia-damiano avatar Jan 09 '23 08:01 curia-damiano

/backport to net7.0

PureWeen avatar Jan 12 '23 15:01 PureWeen

Started backporting to net7.0: https://github.com/dotnet/maui/actions/runs/3903839609

github-actions[bot] avatar Jan 12 '23 15:01 github-actions[bot]