maui
maui copied to clipboard
Fix gestures in Label Spans
Description of Change
Fix gestures in Label Spans.
Android

iOS/Catalyst

Windows (Work in progress)
To test/validate the changes, open the .NET MAUI Gallery and navigate to the Label page. Tap the Span with the text "Click Me". If the Span changes the TextColor, is working as expected.
Issues Fixed
Fixes #4734 Fixes #8004
@jsuarezruiz not sure if you have or havnt, but could you add a test for multiple clickable spans.
There was an issue in XF where if you had multiple spans with tap gestures, if you clicked on the last span, all the previous spans tap gestures would also trigger.
It was fixed, just want to make sure it doesnt crop back up in MAUI - https://github.com/xamarin/Xamarin.Forms/issues/11650
@jsuarezruiz not sure if you have or havnt, but could you add a test for multiple clickable spans.
There was an issue in XF where if you had multiple spans with tap gestures, if you clicked on the last span, all the previous spans tap gestures would also trigger.
It was fixed, just want to make sure it doesnt crop back up in MAUI - https://github.com/xamarin/Xamarin.Forms/issues/11650
Good point, I've checked it.

@pictos also wondering if tap gestures will be updated in maui to support keyboard accessibility?
In XF navigating with a keyboard, tap gestured controls were skipped over.
@pictos also wondering if tap gestures will be updated in maui to support keyboard accessibility?
In XF navigating with a keyboard, tap gestured controls were skipped over.
@PureWeen , I belive you have more context to answer this question
Hi @jsuarezruiz thank you for hard work on implementing this one, as well as other things on MAUI. Do we have ETA for having this in production?
Best regards, Sadam
Pulling this out of draft, need someone to diagnose the failures from the Android API 23 tests.
:warning: Your code has been reformatted. :warning:
Thank you for your pull request. We are auto-formating your source code to follow our code guidelines.
This PR affects all platforms, and has quite a few changes here and there. To facilitate its review and have fixes in releases as soon as possible, I am going to close this PR to open smaller PRs focused on each platform.