maui icon indicating copy to clipboard operation
maui copied to clipboard

Fix gestures in Label Spans

Open jsuarezruiz opened this issue 2 years ago • 8 comments

Description of Change

Fix gestures in Label Spans.

Android fix-gestures-span-droid image

iOS/Catalyst fix-gestures-span-ios

Windows (Work in progress)

To test/validate the changes, open the .NET MAUI Gallery and navigate to the Label page. Tap the Span with the text "Click Me". If the Span changes the TextColor, is working as expected.

Issues Fixed

Fixes #4734 Fixes #8004

jsuarezruiz avatar Dec 12 '22 12:12 jsuarezruiz

@jsuarezruiz not sure if you have or havnt, but could you add a test for multiple clickable spans.

There was an issue in XF where if you had multiple spans with tap gestures, if you clicked on the last span, all the previous spans tap gestures would also trigger.

It was fixed, just want to make sure it doesnt crop back up in MAUI - https://github.com/xamarin/Xamarin.Forms/issues/11650

IeuanWalker avatar Dec 19 '22 16:12 IeuanWalker

@jsuarezruiz not sure if you have or havnt, but could you add a test for multiple clickable spans.

There was an issue in XF where if you had multiple spans with tap gestures, if you clicked on the last span, all the previous spans tap gestures would also trigger.

It was fixed, just want to make sure it doesnt crop back up in MAUI - https://github.com/xamarin/Xamarin.Forms/issues/11650

Good point, I've checked it. multiple-spans-click

jsuarezruiz avatar Dec 20 '22 15:12 jsuarezruiz

@pictos also wondering if tap gestures will be updated in maui to support keyboard accessibility?

In XF navigating with a keyboard, tap gestured controls were skipped over.

IeuanWalker avatar Dec 30 '22 23:12 IeuanWalker

@pictos also wondering if tap gestures will be updated in maui to support keyboard accessibility?

In XF navigating with a keyboard, tap gestured controls were skipped over.

@PureWeen , I belive you have more context to answer this question

pictos avatar Dec 31 '22 05:12 pictos

Hi @jsuarezruiz thank you for hard work on implementing this one, as well as other things on MAUI. Do we have ETA for having this in production?

Best regards, Sadam

SadamSkula avatar Jan 23 '23 13:01 SadamSkula

Pulling this out of draft, need someone to diagnose the failures from the Android API 23 tests.

hartez avatar Feb 06 '23 20:02 hartez

:warning: Your code has been reformatted. :warning:

github-actions[bot] avatar Feb 15 '23 09:02 github-actions[bot]

Thank you for your pull request. We are auto-formating your source code to follow our code guidelines.

github-actions[bot] avatar Mar 03 '23 11:03 github-actions[bot]

This PR affects all platforms, and has quite a few changes here and there. To facilitate its review and have fixes in releases as soon as possible, I am going to close this PR to open smaller PRs focused on each platform.

jsuarezruiz avatar Apr 05 '23 12:04 jsuarezruiz