maui icon indicating copy to clipboard operation
maui copied to clipboard

Published 20 hours ago • verified publisher icon dotnet

[Android] Fix crash disconnecting the IndicatorView

Open jsuarezruiz opened this issue 3 years ago • 1 comments
trafficstars

Description of Change

Fix crash disconnecting the IndicatorView on Android.

Issues Fixed

Fixes #11310

jsuarezruiz avatar Nov 14 '22 16:11 jsuarezruiz

@jsuarezruiz can you add a test for this? Given this didn't cause any tests to fail I assume we don't have coverage - maybe there's an opportunity here to add a test that covers disconnect for all handler cases?

Yes, good suggestions. We have a test that validates the disconnection of handlers. However, it only does it in those controls where we have the Stub and tests. I have added what is necessary to pass the tests with the IndicatorViewHandler.

image

In another PR I will review adding the pending controls and in another validate basic properties of the IndicatorView (Background, Count etc).

jsuarezruiz avatar Nov 24 '22 11:11 jsuarezruiz

/backport to net7.0

mattleibow avatar Dec 15 '22 15:12 mattleibow

Started backporting to net7.0: https://github.com/dotnet/maui/actions/runs/3705705016

github-actions[bot] avatar Dec 15 '22 15:12 github-actions[bot]