dotnet
FlyoutItemIsVisible should accept a "BindableObject" (i.e. it should be data bound)
Description
In my application I adjust flyout items dynamically. Whereas "FlyoutItem.IsVisible" accepts a BindableObject, "FlyoutItemIsVisible" does not. This seems like an oversight to me.
On a related note, changing the "FlyoutItemIsVisible" dynamically changes its order in the list. This seems like a bug to me, but it's possible that addressing the former will also address the latter.
Public API Changes
Microsoft.Maui.Controls.BaseShellItem.FlyoutItemIsVisible
Intended Use-Case
Data binding my shell to a view model.
We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.
related to https://github.com/dotnet/maui/issues/10961
@PureWeen what are your thoughts here?
Maybe this is because we have a bad name here?
https://github.com/dotnet/maui/blob/main/src/Controls/src/Core/Shell/Shell.cs#L71-L72
public static readonly BindableProperty FlyoutItemIsVisibleProperty =
BindableProperty.CreateAttached(nameof(IsVisible), typeof(bool), typeof(Shell), true, propertyChanged: OnFlyoutItemIsVisibleChanged);
@mattleibow I'm keen for this bug to be fixed, so I've put in a PR with your suggestion (I hope this helps). I've not been able to test it as I've tried and failed in the past to get a local build environment set up without borking my normal development environment. Do you have any dev box VM images that .NET Maui contributors can use to test things with?
