maui icon indicating copy to clipboard operation
maui copied to clipboard

Published 20 hours ago • verified publisher icon dotnet

Revert "[Windows] Fix default corner radius on Button"

Open tj-devel709 opened this issue 2 years ago • 5 comments

Reverts dotnet/maui#9515

dotnet/maui#9515 Allows all the platforms to have the same default button border radius, but we want to keep the Windows default rounded corner style on buttons. Thanks @mattleibow and @PureWeen for spotting this! Also peer programmed with @rachelkang!

Before the revert (no rounded corners): Screen Shot 2022-10-12 at 3 34 27 PM

After the revert (rounded corners): Screen Shot 2022-10-13 at 10 43 38 AM

Fixes #10644

tj-devel709 avatar Oct 13 '22 16:10 tj-devel709

Hey there @tj-devel709! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

ghost avatar Oct 13 '22 16:10 ghost

Fixes #10644

rachelkang avatar Oct 13 '22 19:10 rachelkang

/azp run

mattleibow avatar Oct 13 '22 21:10 mattleibow

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Oct 13 '22 21:10 azure-pipelines[bot]

I added a small test to make sure the radius of the WinUI does not get set back to zero. Small photo added since I didn't realize the default button corner radius set is -1 which is rounded as well! Screen Shot 2022-10-13 at 9 34 06 PM

tj-devel709 avatar Oct 14 '22 03:10 tj-devel709

/azp run

mattleibow avatar Oct 16 '22 08:10 mattleibow

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Oct 16 '22 08:10 azure-pipelines[bot]

The value of -1 means default rounding. So whatever the OS decides.

mattleibow avatar Oct 16 '22 08:10 mattleibow