machinelearning icon indicating copy to clipboard operation
machinelearning copied to clipboard

update torchsharp to 0.105.0

Open LittleLittleCloud opened this issue 9 months ago • 5 comments

We are excited to review your PR.

So we can do the best job, please check:

  • [x] There's a descriptive title that will make sense to other developers some time from now.
  • [ ] There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • [x] Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • [ ] You have included any necessary tests in the same PR.

LittleLittleCloud avatar Mar 12 '25 00:03 LittleLittleCloud

Which feed are these new versions published to? If only nuget.org, should they be mirrored?

ericstj avatar Mar 12 '25 01:03 ericstj

Yes it needs mirroring. Being done here, https://dev.azure.com/dnceng/internal/_build/results?buildId=2676108&view=results.

michaelgsharp avatar Mar 31 '25 22:03 michaelgsharp

/azp run

michaelgsharp avatar Mar 31 '25 22:03 michaelgsharp

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Mar 31 '25 22:03 azure-pipelines[bot]

Ah, I think I remember now. The reason we had stayed on the old version was that these newer versions don't support OSX-x64. So its gonna require a bit more work to swap versions @LittleLittleCloud. Going to have to stop torch sharp from building on osx x64 and skip those tests there as well. We've dont something similar in ML.NET for x86, but now it will need to be expanded to this as well.

michaelgsharp avatar Mar 31 '25 23:03 michaelgsharp