machinelearning icon indicating copy to clipboard operation
machinelearning copied to clipboard

Use new System.Numerics.Tensors library for DataFrame arithmetic operations (.net8)

Open asmirnov82 opened this issue 1 year ago • 2 comments

Use new System.Numerics.Tensors library for DataFrame arithmetic operations (.net8)

Fixes #7178

The aim of this PR to use new library for DataFrame arithmetic operations instead of custom implemtation. At the same time provide backward compatibility for pre-.Net8.0 versions of the package. To achive this, all .,net version specific code is localised in nested private classes of static class Arithmetic that implements IArithmetic<T> interface and are not used directly by any other DataFrame classes

asmirnov82 avatar Jun 19 '24 08:06 asmirnov82

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.80%. Comparing base (579fe03) to head (da20f4d). Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7179      +/-   ##
==========================================
- Coverage   69.06%   68.80%   -0.27%     
==========================================
  Files        1401     1267     -134     
  Lines      268516   259501    -9015     
  Branches    27812    26910     -902     
==========================================
- Hits       185451   178546    -6905     
+ Misses      75902    74083    -1819     
+ Partials     7163     6872     -291     
Flag Coverage Δ
Debug 68.80% <0.00%> (-0.27%) :arrow_down:
production 63.07% <0.00%> (-0.58%) :arrow_down:
test 88.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ta.Analysis/Computations/Arithmetic.netstandard.cs 45.64% <ø> (ø)
....Analysis.Tests/DataFrameTests.BinaryOperations.cs 100.00% <ø> (ø)
...Microsoft.Data.Analysis/Computations/Arithmetic.cs 57.74% <0.00%> (-6.63%) :arrow_down:

... and 137 files with indirect coverage changes

codecov[bot] avatar Jun 20 '24 08:06 codecov[bot]

cc @michaelgsharp @tannergooding

ericstj avatar Jun 24 '24 20:06 ericstj

/azp run

JakeRadMSFT avatar Jul 24 '24 10:07 JakeRadMSFT

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Jul 24 '24 10:07 azure-pipelines[bot]