machinelearning icon indicating copy to clipboard operation
machinelearning copied to clipboard

Packaging cleanup

Open ericstj opened this issue 1 year ago • 9 comments

Originally I was just trying to remove mentions of snupkg, but then things got a bit carried away. :)

This is trying to remove as much duplication and dead code related to packaging that I can.

I'll be validating these changes with diffs and refining a bit more but wanted to get this up and see if CI is happy.

ericstj avatar Jan 05 '24 00:01 ericstj

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.79%. Comparing base (0d2fd60) to head (59f414d). Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6939      +/-   ##
==========================================
- Coverage   68.83%   68.79%   -0.05%     
==========================================
  Files        1258     1254       -4     
  Lines      250674   250204     -470     
  Branches    25615    25529      -86     
==========================================
- Hits       172557   172128     -429     
+ Misses      71486    71466      -20     
+ Partials     6631     6610      -21     
Flag Coverage Δ
Debug 68.79% <ø> (-0.05%) :arrow_down:
production 63.22% <ø> (-0.06%) :arrow_down:
test 88.50% <ø> (-0.07%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

see 29 files with indirect coverage changes

codecov[bot] avatar Jan 05 '24 01:01 codecov[bot]

Still something wonky happening with the build of the analyzer that I haven't quite determined. Looks to me like it's building concurrently in two separate processes.

Here's the nuspec diff of the current changes. https://github.com/ericstj/diffs/commit/ecf911b5ccd4ec488d08ba7a9f7d4a5c8f1cba4a

ericstj avatar Jan 08 '24 23:01 ericstj

/azp run MachineLearning-CI

ericstj avatar Jan 26 '24 23:01 ericstj

Pull request contains merge conflicts.

azure-pipelines[bot] avatar Jan 26 '24 23:01 azure-pipelines[bot]

/azp run MachineLearning-CI

ericstj avatar Feb 13 '24 17:02 ericstj

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Feb 13 '24 17:02 azure-pipelines[bot]

I'm going to rename the projects to CSProj and put everything in the sln to make this work better with fewer custom steps.

ericstj avatar Feb 13 '24 18:02 ericstj

@michaelgsharp/@viktorhofer can you take another look at this? I'm going to stop short of pipeline refactoring on this and do that in a separate PR.

ericstj avatar Feb 22 '24 18:02 ericstj

Here's an updated diff of NuSpecs, comparing the latest from main with the updates in this PR: https://github.com/ericstj/diffs/commit/26178c06087ac37c140a6bcac94ea6b3b1efb8ab

ericstj avatar Feb 22 '24 18:02 ericstj