machinelearning icon indicating copy to clipboard operation
machinelearning copied to clipboard

Published 20 hours ago • verified publisher icon dotnet

File-scoped namespaces in files directly under `Microsoft.ML.Core`

Open Lehonti opened this issue 2 years ago • 6 comments

Lehonti avatar Aug 10 '23 20:08 Lehonti

/azp run

michaelgsharp avatar Aug 25 '23 20:08 michaelgsharp

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Aug 25 '23 20:08 azure-pipelines[bot]

@Lehonti I'm not quite sure yet why, but for some reason these changes are tripping a test where we make sure [BestFriends] isn't applied on public members. Don't see that in this PR though so not sure why its happening. Could be an incorrect test?

michaelgsharp avatar Sep 01 '23 03:09 michaelgsharp

@Lehonti I'm not quite sure yet why, but for some reason these changes are tripping a test where we make sure [BestFriends] isn't applied on public members. Don't see that in this PR though so not sure why its happening. Could be an incorrect test?

Yes, I think it's probably an incorrect test. I don't know enough about the project so I refrained from modifying anything that could possibly alter the behavior of the code, and stuck to what I'm describing in the pull request (namely file-scoped namespaces). I usually do small changes like these when I'm just getting acquainted with a project.

Lehonti avatar Sep 05 '23 15:09 Lehonti

/azp run

michaelgsharp avatar Dec 07 '23 20:12 michaelgsharp

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Dec 07 '23 20:12 azure-pipelines[bot]