machinelearning icon indicating copy to clipboard operation
machinelearning copied to clipboard

Update public pool names

Open alexperovich opened this issue 3 years ago • 3 comments

This change is required for builds to continue working in the new org, dev.azure.com/dnceng-public.

alexperovich avatar Sep 01 '22 01:09 alexperovich

/azp run

ericstj avatar Sep 14 '22 20:09 ericstj

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Sep 14 '22 20:09 azure-pipelines[bot]

Codecov Report

Merging #6312 (b495f06) into main (9652e59) will increase coverage by 0.06%. The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6312      +/-   ##
==========================================
+ Coverage   68.56%   68.63%   +0.06%     
==========================================
  Files        1170     1170              
  Lines      247158   247323     +165     
  Branches    25675    25683       +8     
==========================================
+ Hits       169475   169750     +275     
+ Misses      70940    70849      -91     
+ Partials     6743     6724      -19     
Flag Coverage Δ
Debug 68.63% <ø> (+0.06%) :arrow_up:
production 63.07% <ø> (+0.06%) :arrow_up:
test 89.05% <ø> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 79.48% <0.00%> (-20.52%) :arrow_down:
...Microsoft.ML.AutoML.Tests/AutoMLExperimentTests.cs 92.38% <0.00%> (-7.62%) :arrow_down:
src/Microsoft.ML.Maml/MAML.cs 25.38% <0.00%> (-1.53%) :arrow_down:
...rc/Microsoft.ML.SearchSpace/Option/ChoiceOption.cs 97.56% <0.00%> (-0.06%) :arrow_down:
.../Microsoft.ML.SearchSpace.Tests/SearchSpaceTest.cs 100.00% <0.00%> (ø)
...Microsoft.ML.SearchSpace.Tests/ChoiceOptionTest.cs 100.00% <0.00%> (ø)
src/Microsoft.ML.FastTree/FastTree.cs 80.48% <0.00%> (+0.07%) :arrow_up:
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.53% <0.00%> (+0.14%) :arrow_up:
...osoft.ML.Tests/TrainerEstimators/TreeEstimators.cs 97.80% <0.00%> (+0.19%) :arrow_up:
src/Microsoft.ML.LightGbm/LightGbmTrainerBase.cs 79.77% <0.00%> (+0.30%) :arrow_up:
... and 10 more

codecov[bot] avatar Sep 14 '22 22:09 codecov[bot]

Is this blocked by something specific, or should we rerun these skipped tests?

dakersnar avatar Oct 10 '22 19:10 dakersnar

@alexperovich can merge this or anything else need to be done?

tarekgh avatar Oct 10 '22 22:10 tarekgh

This can be merged.

alexperovich avatar Oct 10 '22 22:10 alexperovich

@alexperovich why are we manually changing things under eng/common -- shouldn't we instead just flow arcade?

ericstj avatar Oct 11 '22 02:10 ericstj

The next arcade update contains this, but this was just an automatic change to get things running asap


From: Eric StJohn @.> Sent: Monday, October 10, 2022 7:28:15 PM To: dotnet/machinelearning @.> Cc: Alex Perovich @.>; Mention @.> Subject: Re: [dotnet/machinelearning] Update public pool names (PR #6312)

@alexperovichhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Falexperovich&data=05%7C01%7CAlex.Perovich%40microsoft.com%7Cf36f8fe00b2449d3a1c808daab3040c1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638010520985322864%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=E61SLjsmGrk3%2FriEzQ2naPXe6VWRICI8hw2uV59IlaI%3D&reserved=0 why are we manually changing things under eng/common -- shouldn't we instead just flow arcade?

— Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2Fmachinelearning%2Fpull%2F6312%23issuecomment-1274008311&data=05%7C01%7CAlex.Perovich%40microsoft.com%7Cf36f8fe00b2449d3a1c808daab3040c1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638010520985322864%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Ma1NjpeAqafAgofoF6ZJz0wbMS5DYbUELafpyXJYIiQ%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACQTOIR3IL2L3DLGTFNNRZLWCTGD7ANCNFSM6AAAAAAQB45PLM&data=05%7C01%7CAlex.Perovich%40microsoft.com%7Cf36f8fe00b2449d3a1c808daab3040c1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638010520985322864%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=PlQIeGl4G0%2F9XD00rPyKo93OoIGAwzP%2BciIcK3917Ok%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

alexperovich avatar Oct 11 '22 19:10 alexperovich