interactive icon indicating copy to clipboard operation
interactive copied to clipboard

Incorrect tooltip for Execute Cell button on Linux

Open IntegerMan opened this issue 1 year ago • 4 comments

Describe the bug

I'm running Polyglot on Pop!_OS 22.04 (a flavor of Ubuntu 22.04) and building text for the book and noticed an incorrect shortcut key for the "Execute Cell" button describing the shortcut as Super + Enter. Super is a substitute for the Windows key on most keyboards. The correct shortcut is still Control + Enter as it is in Windows.

Please complete the following:

Which version of .NET Interactive are you using? (In a notebook, run the #!about magic command. ):

  • OS
    • [ ] Windows 11
    • [ ] Windows 10
    • [ ] macOS
    • [x] Linux (Pop!_OS 22.04)
    • [ ] iOS
    • [ ] Android
  • Browser
    • [ ] Chrome
    • [ ] Edge
    • [ ] Firefox
    • [ ] Safari
  • Frontend
    • [ ] Jupyter Notebook
    • [ ] Jupyter Lab
    • [ ] nteract
    • [x] Visual Studio Code
    • [ ] Visual Studio Code Insiders
    • [ ] Visual Studio
    • [ ] Other (please specify)

Screenshots

image

IntegerMan avatar Feb 24 '24 02:02 IntegerMan

This is likely more than just the execute cell shortcut. I just noticed a mistake on the validate markdown shortcut as well: image

I'd recommend reviewing Linux shortcuts for correctness.

IntegerMan avatar Feb 24 '24 04:02 IntegerMan

This is VS Code functionality, not Polyglot Notebooks.

@rebornix Is this on your radar?

jonsequitur avatar Mar 05 '24 19:03 jonsequitur

We are using ctrl+enter as the default keybindings

primary: KeyMod.WinCtrl | KeyCode.Enter,
win: {
	primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.Enter
},

@IntegerMan do you have the Jupyter Keymap installed?

rebornix avatar Mar 05 '24 19:03 rebornix

@rebornix I did indeed. I didn't think I did since I have a very minimal install in a new workspace, but perhaps I added it and don't remember doing so. Disabling that gives me better tooltips for the Stop Editing Cell, but not the execute cell shortcut: image Note that the keymap is disabled in this screenshot.

IntegerMan avatar Mar 08 '24 04:03 IntegerMan