installer icon indicating copy to clipboard operation
installer copied to clipboard
verified publisher icon dotnet

[main] Update dependencies from dotnet/sdk

Open dotnet-maestro[bot] opened this issue 1 year ago • 10 comments

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency attribute were produced in a build used as input to the parent dependency's build. See Dependency Description Format

  • Coherency Updates:
    • Microsoft.WindowsDesktop.App.Ref: from 9.0.0-preview.4.24220.1 to 9.0.0-preview.5.24229.3 (parent: Microsoft.NET.Sdk)
    • VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0: from 9.0.0-preview.4.24220.1 to 9.0.0-preview.5.24229.3 (parent: Microsoft.NET.Sdk)
    • VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0: from 9.0.0-preview.4.24220.1 to 9.0.0-preview.5.24229.3 (parent: Microsoft.NET.Sdk)
    • VS.Redist.Common.NetCore.SharedFramework.x64.9.0: from 9.0.0-preview.4.24223.11 to 9.0.0-preview.4.24229.16 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.App.Ref: from 9.0.0-preview.4.24223.11 to 9.0.0-preview.4.24229.16 (parent: Microsoft.NET.Sdk)
    • VS.Redist.Common.NetCore.TargetingPack.x64.9.0: from 9.0.0-preview.4.24223.11 to 9.0.0-preview.4.24229.16 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.App.Host.win-x64: from 9.0.0-preview.4.24223.11 to 9.0.0-preview.4.24229.16 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.Platforms: from 9.0.0-preview.4.24223.11 to 9.0.0-preview.4.24229.16 (parent: Microsoft.NET.Sdk)
    • Microsoft.SourceBuild.Intermediate.runtime.linux-x64: from 9.0.0-preview.4.24223.11 to 9.0.0-preview.4.24229.16 (parent: Microsoft.NET.Sdk)
    • Microsoft.AspNetCore.App.Ref: from 9.0.0-preview.4.24223.1 to 9.0.0-preview.5.24225.4 (parent: Microsoft.NET.Sdk)
    • Microsoft.AspNetCore.App.Ref.Internal: from 9.0.0-preview.4.24223.1 to 9.0.0-preview.5.24225.4 (parent: Microsoft.NET.Sdk)
    • Microsoft.AspNetCore.App.Runtime.win-x64: from 9.0.0-preview.4.24223.1 to 9.0.0-preview.5.24225.4 (parent: Microsoft.NET.Sdk)
    • VS.Redist.Common.AspNetCore.SharedFramework.x64.9.0: from 9.0.0-preview.4.24223.1 to 9.0.0-preview.5.24225.4 (parent: Microsoft.NET.Sdk)
    • dotnet-dev-certs: from 9.0.0-preview.4.24223.1 to 9.0.0-preview.5.24225.4 (parent: Microsoft.NET.Sdk)
    • dotnet-user-jwts: from 9.0.0-preview.4.24223.1 to 9.0.0-preview.5.24225.4 (parent: Microsoft.NET.Sdk)
    • dotnet-user-secrets: from 9.0.0-preview.4.24223.1 to 9.0.0-preview.5.24225.4 (parent: Microsoft.NET.Sdk)
    • Microsoft.SourceBuild.Intermediate.aspnetcore: from 9.0.0-preview.4.24223.1 to 9.0.0-preview.5.24225.4 (parent: Microsoft.NET.Sdk)
    • Microsoft.DotNet.Test.ProjectTemplates.9.0: from 1.1.0-rc.24222.1 to 1.1.0-rc.24229.2 (parent: Microsoft.NET.Sdk)
    • Microsoft.SourceBuild.Intermediate.test-templates: from 1.1.0-rc.24222.1 to 1.1.0-rc.24229.2 (parent: Microsoft.NET.Sdk)
    • Microsoft.WindowsDesktop.App.Runtime.win-x64: from 9.0.0-preview.4.24220.1 to 9.0.0-preview.5.24229.3 (parent: Microsoft.NET.Sdk)
    • Microsoft.Dotnet.WinForms.ProjectTemplates: from 9.0.0-preview.4.24218.1 to 9.0.0-preview.5.24228.1 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)
    • Microsoft.WindowsDesktop.App.Runtime.win-x64: from 9.0.0-preview.4.24220.1 to 9.0.0-preview.5.24229.3 (parent: Microsoft.NET.Sdk)
    • Microsoft.DotNet.Wpf.ProjectTemplates: from 9.0.0-preview.4.24219.1 to 9.0.0-preview.5.24229.1 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)
    • Microsoft.FSharp.Compiler: from 12.8.400-beta.24223.1 to 12.8.400-beta.24229.4 (parent: Microsoft.NET.Sdk)
    • Microsoft.SourceBuild.Intermediate.fsharp: from 8.0.400-beta.24223.1 to 8.0.400-beta.24229.4 (parent: Microsoft.NET.Sdk)
    • Microsoft.NET.ILLink.Tasks: from 9.0.0-preview.4.24223.11 to 9.0.0-preview.4.24229.16 (parent: Microsoft.NET.Sdk)
    • Microsoft.Net.Compilers.Toolset: from 4.11.0-1.24223.5 to 4.11.0-2.24229.6 (parent: Microsoft.NET.Sdk)
    • Microsoft.SourceBuild.Intermediate.roslyn: from 4.11.0-1.24223.5 to 4.11.0-2.24229.6 (parent: Microsoft.NET.Sdk)
    • Microsoft.Build: from 17.11.0-preview-24222-11 to 17.11.0-preview-24223-07 (parent: Microsoft.NET.Sdk)
    • Microsoft.SourceBuild.Intermediate.msbuild: from 17.11.0-preview-24222-11 to 17.11.0-preview-24223-07 (parent: Microsoft.NET.Sdk)
    • NuGet.Build.Tasks: from 6.11.0-preview.1.28 to 6.11.0-preview.1.32 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.App.Runtime.win-x64: from 9.0.0-preview.4.24223.11 to 9.0.0-preview.4.24229.16 (parent: Microsoft.NET.Sdk)
    • Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport: from 9.0.0-preview.4.24215.3 to 9.0.0-preview.5.24223.2 (parent: Microsoft.NETCore.App.Runtime.win-x64)
    • Microsoft.NETCore.App.Runtime.win-x64: from 9.0.0-preview.4.24223.11 to 9.0.0-preview.4.24229.16 (parent: Microsoft.NET.Sdk)
    • Microsoft.SourceBuild.Intermediate.emsdk: from 9.0.0-preview.4.24215.3 to 9.0.0-preview.5.24223.2 (parent: Microsoft.NETCore.App.Runtime.win-x64)
    • Microsoft.DotNet.Darc: from 1.1.0-beta.24210.2 to 1.1.0-beta.24229.1 (parent: Microsoft.NET.Sdk)
    • Microsoft.DotNet.DarcLib: from 1.1.0-beta.24210.2 to 1.1.0-beta.24229.1 (parent: Microsoft.NET.Sdk)
    • Microsoft.NET.Sdk.Aspire.Manifest-9.0.100-preview.1: from 9.0.0-preview.4.24218.6 to 9.0.0-preview.4.24229.9 (parent: Microsoft.NET.Sdk)
    • Microsoft.SourceBuild.Intermediate.aspire: from 9.0.0-preview.4.24218.6 to 9.0.0-preview.4.24229.9 (parent: Microsoft.NET.Sdk)

From https://github.com/dotnet/sdk

  • Subscription: 98f94ba0-dbc5-44e4-808a-08dc434c168d
  • Build: 20240430.4
  • Date Produced: April 30, 2024 12:07:41 PM UTC
  • Commit: bf1a34dff80879a58f01c1b4a6f765b5f9dd985e
  • Branch: refs/heads/main

dotnet-maestro[bot] avatar Apr 26 '24 06:04 dotnet-maestro[bot]

Notification for subscribed users from https://github.com/dotnet/sdk:

@dotnet/domestic-cat

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/sdk) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

dotnet-maestro[bot] avatar Apr 26 '24 06:04 dotnet-maestro[bot]

@ViktorHofer are these downgrades accidental?

kasperk81 avatar Apr 29 '24 17:04 kasperk81

One downgrade should get fixed with https://github.com/dotnet/sdk/pull/40538. I don't understand the other ones though (scenario-tests and test-templates 9.0 package)

ViktorHofer avatar Apr 29 '24 19:04 ViktorHofer

cc @marcpopMSFT @MiYanni regarding the downgrades

ViktorHofer avatar Apr 29 '24 19:04 ViktorHofer

They should be flowing from SDK now. I think the downgrades are from Yanni's initial insertion of installer source into sdk but the follow up codeflows should have resolved that. https://github.com/dotnet/sdk/pull/40457 https://github.com/dotnet/sdk/pull/40530

marcpopMSFT avatar Apr 29 '24 20:04 marcpopMSFT

Microsoft.DotNet.Test.ProjectTemplates.8.0 was downgraded from 1.1.0-rc.24202.1 to 1.1.0-rc.24120.2

https://github.com/dotnet/sdk/pull/40538 was picked up by c5d3b60 yet the error persists

kasperk81 avatar Apr 29 '24 21:04 kasperk81

Yeah this seems broken. cc @premun @tkapin

ViktorHofer avatar Apr 30 '24 07:04 ViktorHofer

https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet9/NuGet/Microsoft.DotNet.Test.ProjectTemplates.8.0/versions last publish date Apr 2, coherency bot is downgrading to version from Feb 20 https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet9-transport/NuGet/Microsoft.SourceBuild.Intermediate.scenario-tests/versions/ last publish date Apr 23, coherency downgrading to version from Jan 7

coherency update is going back in time and sdk is not publishing new versions of test packages anymore? double mystery

kasperk81 avatar Apr 30 '24 08:04 kasperk81

I disabled the subscription and reverted the commit that brings a newer runtime in which would need a re-bootstrap. Let's see if this works. That commit also has https://github.com/dotnet/runtime/commit/3e569f5696ddf6c93e56eeaaf1703bb64e561f1b & https://github.com/dotnet/runtime/commit/1c824d929b734db420babbc04f44a1491d8a7efb which are necessary (see https://github.com/dotnet/source-build/issues/4362#issuecomment-2087729723).

ViktorHofer avatar May 01 '24 06:05 ViktorHofer

  1. why are newer versions of Microsoft.DotNet.Test.ProjectTemplates.8.0 and Microsoft.SourceBuild.Intermediate.scenario-tests not being published to nuget galleries?
  2. why is the coherency bot using the four months old version instead of the latest one (even the latest one is a week old but that's a separate issue covered by 1.)

answer these two questions and it will get things rolling

kasperk81 avatar May 01 '24 10:05 kasperk81

answer these two questions and it will get things rolling

I disabled the subscription and fixed the downgrades. Yes, we need to figure this out, but not right now as part of this PR.

The failing "Maestro auto-merge - Do not automerge downgrades" leg is a false positive. Presumably, it looks at all commits in the PR.

why is the coherency bot using the four months old version instead of the latest one (even the latest one is a week old but that's a separate issue covered by 1.)

That has to do with the repo merge. We need to get this PR merged as it still contains commits before the repo merge which confuses Maestro.

why are newer versions of Microsoft.DotNet.Test.ProjectTemplates.8.0

Microsoft.DotNet.Test.ProjectTemplates.8.0 isn't live built anymore, it got deleted with https://github.com/dotnet/test-templates/commit/3c37712adb7b45506e8445f349367222b35a97dd

ViktorHofer avatar May 01 '24 11:05 ViktorHofer

vmr's sdk build failing

/vmr/src/sdk/src/Installer/redist-installer/targets/GenerateLayout.targets(398,5): error : Download from all targets failed. List of attempted targets: https://dotnetcli.blob.core.windows.net/dotnet/Runtime/9.0.0-preview.4.24225.8/dotnet-runtime-9.0.0-preview.4.24225.8-linux-x64.tar.gz [/vmr/src/sdk/src/Installer/redist-installer/redist-installer.csproj]

kasperk81 avatar May 01 '24 12:05 kasperk81

@marcpopMSFT can you please mark the "installer-unified-build" pipeline in the repo settings as non required for the main branch? We need to merge this PR even if the unified build pipeline fails because we are in a weird state right now.

ViktorHofer avatar May 01 '24 15:05 ViktorHofer

@marcpopMSFT can you please mark the "installer-unified-build" pipeline in the repo settings as non required for the main branch? We need to merge this PR even if the unified build pipeline fails because we are in a weird state right now.

I removed the required check.

MichaelSimons avatar May 01 '24 15:05 MichaelSimons