installer
installer copied to clipboard
dotnet
MacOs installer resources are unlocalized
Mac installer resources appear to have a localized layout https://github.com/dotnet/installer/tree/main/src/redist/targets/packaging/osx/clisdk/resources
However nothing in the build process applies translations to these and their final state in the installer pkg is the same as it is in source control.
This doesn't appear to be a regression. I spot checked 5.0 and it was the same. Not sure if these were ever localized or not.
I added some script usage of installation-check downlevel that has user-visible strings in script. We're unlikely to change that downlevel even if we fix loc for 6.0 or 7.0, however if we did we could use https://developer.apple.com/documentation/installer_js/system/1812321-localizedstring.
@richaverma1 @cristianosuzuki77 it looks like there are localizable resources but they've never been translated. I don't think these are plugged into our existing translation process. Is there a way to get them one-off manually translated?
@marcpopMSFT dotnet/installer repo was not on my radar. Does your team own the localization for it? I was only tracking dotnet/sdk
My team owns it but note that there are very few strings here. It's only the installers themselves which don't use the xlf form.
@marcpopMSFT is the repo on Arcade? And if the strings are in the main branch then translation team will be able to pick it up for translation. If the branch is not main then a repo modification ticket needs to be opened, as mentioned in https://github.com/dotnet/arcade/blob/main/Documentation/OneLocBuild.md
We would want the 6.0.1xx branch to be updated if we want this for GA. Since this has shipped this way for multiple releases, I'd probably focus on 6.0.2xx for this.
@marcpopMSFT there will be a separate Loc pass for 17.1 and I have made a note to check with you on this repo at that time.
Old issue triage: This was completed after https://github.com/dotnet/installer/pull/15334