fsharp icon indicating copy to clipboard operation
fsharp copied to clipboard

Implement #elif preprocessor directive

Open Thorium opened this issue 2 months ago • 6 comments

Implement #elif preprocessor directive

Fix for https://github.com/fsharp/fslang-suggestions/issues/1370

Checklist

  • [x] Test cases added
  • [ ] Performance benchmarks added in case of performance changes
  • [x] Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

Edit: RFC

Thorium avatar Nov 02 '25 09:11 Thorium

:heavy_exclamation_mark: Release notes required


:white_check_mark: Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/11.0.0.md

github-actions[bot] avatar Nov 02 '25 09:11 github-actions[bot]

Nice work. But this is not a fix, but a new feature that needs an RFC. (Which should also document the effect on tooling (where it is / can be a breaking change).

Martin521 avatar Nov 02 '25 09:11 Martin521

Thank you for the contribution. The RFC makes sense, it also acts as a notification mechanism for other interested parties (IDEs and Fantomas come to mind). Parts of the RFC text on usage should then also make their way into the docs.

It's definitely good to see this early in the F#11 development cycle, as it gives enough time to others for adjustment 👍

T-Gro avatar Nov 03 '25 11:11 T-Gro

How is the RFC process working? Do I have to make it, or someone else?

Thorium avatar Nov 03 '25 12:11 Thorium

How is the RFC process working? Do I have to make it, or someone else?

It is typically created by somebody interested in the feature. The process is described in the readme of the lang-design repo and further documentation is in the RFC template. I think the RFC can be rather brief in this case.

Martin521 avatar Nov 03 '25 14:11 Martin521

The RFC is now approved and merged.

T-Gro avatar Nov 10 '25 10:11 T-Gro