fsharp icon indicating copy to clipboard operation
fsharp copied to clipboard

Split commands.yml into running and saving

Open T-Gro opened this issue 6 months ago • 10 comments

This PR restructures the GH actions into two jobs. First one runs and executes arbitrary code, and is by nature unsafe. It ends with creating a diff patch, and does not have any write permissions to anything. The second job is not user extensible, and applies the diff to the source branch of the PR.

The following comments in a PR can be used as commands to execute scripts which automate repository maintenance and make it part of the visible diff.

  • /run fantomas runs dotnet fantomas .
  • /run ilverify updates IL verification baseline
  • /run xlf refreshes localisation files for translatable strings
  • /run test-baseline ... runs tests with the TEST_UPDATE_BSL: 1 environment variable and an argument supplied filter (passed to dotnet test --filter ..). Its goal is to refresh baselines.

@edgarfgp , @auduchinok : Are there other types of content changes that would also made use of a command, and would not be covered by the above?

T-Gro avatar Jun 12 '25 13:06 T-Gro

:white_check_mark: No release notes required

github-actions[bot] avatar Jun 12 '25 13:06 github-actions[bot]

@T-Gro would be possible to include Re-running the CI ?

edgarfgp avatar Jun 16 '25 09:06 edgarfgp

Will have to figure out how to do it without a dummy commit (my current naive idea) and without risks with exposing the access token. Will check how this is done elsewhere.

T-Gro avatar Jun 16 '25 13:06 T-Gro

Will have to figure out how to do it without a dummy commit (my current naive idea) and without risks with exposing the access token. Will check how this is done elsewhere.

/azp run will rerun the CI, or was it removed?

vzarytovskii avatar Jun 16 '25 15:06 vzarytovskii

/azp run will rerun the CI, or was it removed?

AFAIK it never worked for OSS contributors, who also do not have the "rerun" buttons when seeing the Checks tab on a PR. @edgarfgp : What happens when you try /azp run please?

T-Gro avatar Jun 16 '25 15:06 T-Gro

/azp run

edgarfgp avatar Jun 16 '25 15:06 edgarfgp

Commenter does not have sufficient privileges for PR 18688 in repo dotnet/fsharp

azure-pipelines[bot] avatar Jun 16 '25 15:06 azure-pipelines[bot]

@T-Gro i get Commenter does not have sufficient privileges for PR 18688 in repo dotnet/fsharp

edgarfgp avatar Jun 16 '25 15:06 edgarfgp

/azp run will rerun the CI, or was it removed?

AFAIK it never worked for OSS contributors, who also do not have the "rerun" buttons when seeing the Checks tab on a PR.

@edgarfgp : What happens when you try /azp run please?

Correct, but what if it's person's own PR? I thought arcade folks fixed it - that you can rerun own PR.

vzarytovskii avatar Jun 18 '25 07:06 vzarytovskii

/azp run will rerun the CI, or was it removed?

AFAIK it never worked for OSS contributors, who also do not have the "rerun" buttons when seeing the Checks tab on a PR. @edgarfgp : What happens when you try /azp run please?

Correct, but what if it's person's own PR? I thought arcade folks fixed it - that you can rerun own PR.

Tried in my own PR and did not work. See https://github.com/dotnet/fsharp/pull/18670#issuecomment-2977124473

edgarfgp avatar Jun 18 '25 08:06 edgarfgp