efcore icon indicating copy to clipboard operation
efcore copied to clipboard

Fixes #20604 - Treat ToString as casting to string in the database

Open Danevandy99 opened this issue 1 year ago • 1 comments

Fixes #20604

  • [x] I've read the guidelines for contributing and seen the walkthrough
  • [x] I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • [x] The code builds and tests pass locally (also verified by our automated build checks)
  • [x] Commit messages follow this format:
        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Code follows the same patterns and style as existing code in this repo

Danevandy99 avatar May 11 '24 17:05 Danevandy99

The build Helix task seems to be stuck, but I'm not sure how to fix that.

Danevandy99 avatar May 11 '24 22:05 Danevandy99

@roji #33706 adds functionality that makes ToString on enums more useful when the enum is mapped to an int in the database.

Danevandy99 avatar May 13 '24 13:05 Danevandy99

Yeah, I see - it's just that we probably need to discuss a broader strategy here when it comes to ToString, value conversion, etc. beyond just the enum case.

roji avatar May 13 '24 13:05 roji

Merging changes with https://github.com/dotnet/efcore/pull/33706

Danevandy99 avatar May 15 '24 12:05 Danevandy99