efcore icon indicating copy to clipboard operation
efcore copied to clipboard

OTEL implementation, so far matching EventCounters infrastructure.

Open cincuranet opened this issue 1 year ago • 3 comments

Fixes #25880

cincuranet avatar Apr 29 '24 13:04 cincuranet

@cincuranet @SamMonoRT I know I'm behind on reviewing this, it's high on my list and moving up - early next week for sure.

roji avatar May 17 '24 14:05 roji

@cincuranet I just noticed I was marked as a reviewer on this PR. Is there any specific input you'd like me to provide? I don't have a ton of context on efcore.

adityamandaleeka avatar May 17 '24 18:05 adityamandaleeka

@cincuranet I just noticed I was marked as a reviewer on this PR. Is there any specific input you'd like me to provide? I don't have a ton of context on efcore.

Was mostly if you saw patterns from other Aspire OTEL efforts.

SamMonoRT avatar May 17 '24 19:05 SamMonoRT

@cincuranet answered some questions above.

roji avatar Jun 03 '24 05:06 roji

Could you also add documentation about these counters to https://learn.microsoft.com/en-us/dotnet/core/diagnostics/built-in-metrics please? :)

Those docs are a major way for customers to discover what metrics the .NET platform is providing to them.

noahfalk avatar Jun 06 '24 07:06 noahfalk

@noahfalk WILCO

cincuranet avatar Jun 06 '24 12:06 cincuranet

Thanks! 👍

noahfalk avatar Jun 06 '24 18:06 noahfalk