efcore icon indicating copy to clipboard operation
efcore copied to clipboard

Use [CallerArgumentExpression] for parameterName argument in Check methods

Open stevendarby opened this issue 3 months ago • 3 comments

  • Use [CallerArgumentExpression] for parameterName argument in Check methods
  • Remove explicit setting of parameterName from uses of these methods

Fixes #33523

  • [x] I've read the guidelines for contributing and seen the walkthrough
  • [x] I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • [x] The code builds and tests pass locally (also verified by our automated build checks)
  • [x] Commit messages follow this format:
        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Code follows the same patterns and style as existing code in this repo

stevendarby avatar Apr 12 '24 16:04 stevendarby

@stevendarby just a reminder to request a new review (upper-right corner) when you're done with modifications.

roji avatar Apr 21 '24 19:04 roji

@stevendarby just a ping to make sure you haven't forgotten about this.

roji avatar Apr 29 '24 12:04 roji

@roji sorry for the delay, had some build issues last time I tried to address the comments- I'd just updated to the latest VS preview, not sure if related. Will have another go this evening and post back either way, but if you want to jump in before then please feel free!

stevendarby avatar Apr 29 '24 12:04 stevendarby