efcore icon indicating copy to clipboard operation
efcore copied to clipboard

Test with VB/F# to make sure expression tree differences are handled

Open ajcvickers opened this issue 6 years ago • 3 comments

This is in particular reference to removal of Relinq since it was doing some normalization in this area.

  • [x] VB string equality/comparison, #19681

ajcvickers avatar Jan 31 '19 21:01 ajcvickers

These re-linq transformations handled things like this.

bricelam avatar Feb 01 '19 22:02 bricelam

Note from triage: add a cross-language functional tests project.

ajcvickers avatar Nov 10 '21 20:11 ajcvickers

I've added a VB test suite with coverage for things that we've fixed (string comparisons and checked arithmetic).

We still have a few known bugs:

  • https://github.com/dotnet/efcore/issues/27202
  • https://github.com/dotnet/efcore/issues/29185
  • https://github.com/dotnet/efcore/issues/30773

But I think we can say that the VB part of this issue is done.

bricelam avatar Apr 26 '23 22:04 bricelam

Hi,

Is there any news regarding this problem?

We are testing with EF 8 and still encounter the same problems. The problem is very impactful in our opinion, we have just finished a huge migration work from Entity Framework 4 to .NET 8 + EF 8 but we are experiencing big problems for certain queries due to these mistranslations for VB.NET

Thank you

gaglia avatar Jan 30 '24 07:01 gaglia

@gaglia this is a general issue tracking improving testing for VB/F# - please vote on specific translation issues so that we know what you're blocked by. See the issues linked to just above; if you're running into something that isn't already covered, please open a new issue with a minimal code sample that shows the problematic query.

roji avatar Jan 30 '24 09:01 roji

Hi @roji

I'm experiencing the same problem already reported in issue #31578.

Wrong translation of WHERE with simple filters for string fields

If you need any other information, just let me know. Thank you

gaglia avatar Jan 30 '24 09:01 gaglia

@gaglia then be sure to vote on #31578, which currently has just one vote - that's a big part of how we choose which issues to prioritize.

roji avatar Jan 30 '24 10:01 roji