eShop icon indicating copy to clipboard operation
eShop copied to clipboard

OrderStatusChangedToCancelledIntegrationEvent is not published to the EventBus

Open harshaghanta opened this issue 1 year ago • 3 comments

Not sure, if I am missing something, here.

In src/Ordering.API/Application/DomainEventHandlers/OrderCancelledDomainEventHandler.cs, the Handle method creates the IntegrationEvent, but never submits it to the EventBus. It just add's that event to IntegrationEventLog table using the EventLogService.

image

harshaghanta avatar Jan 17 '24 18:01 harshaghanta

No functionality related to this present in webApp. There is no way to cancel anyorder in web app.

This can be enhancement, if dotnet team agrees on it.

ks1990cn avatar Jan 18 '24 18:01 ks1990cn

@harshaghanta Thanks for reporting this issue!

As @ks1990cn mentioned, we don't support this functionality in the application yet but would welcome a contribution.

It's a fairly medium sized feature so it would be good to sketch out what the necessary code changes would be before opening a PR. I anticipate that at minimum we'd need a UI change and a new API endpoint.

captainsafia avatar Jan 18 '24 22:01 captainsafia

No functionality related to this present in webApp. There is no way to cancel anyorder in web app.

This can be enhancement, if dotnet team agrees on it.

Cancel functionality exists in the SPA at least. User will be able to cancel the order , till the Ordering.background task picks the order. image

Isn't adding the below line of code enough.

await _orderingIntegrationEventService.PublishEventsThroughEventBusAsync(Guid.NewGuid());

harshaghanta avatar Jan 20 '24 06:01 harshaghanta