dotnet
Support adding items to cart without logging in
closes https://github.com/dotnet/eShop/issues/27 , changes are related to WebApp.
I want to propose an idea to store cart objects into session untill user log-in. When user log-in, this session cart will be converted into redis cart for user.
@captainsafia are you going to review this or anyone else will continue with review process? 😕
@ks1990cn Considering the scope of this change, we may want to incorporate other reviewers in here, but I can take a look for now.
Have you verified that this works end-to-end? I'm not able to checkout after adding an item to the cart while being logged out.
@ks1990cn Considering the scope of this change, we may want to incorporate other reviewers in here, but I can take a look for now.
Have you verified that this works end-to-end? I'm not able to checkout after adding an item to the cart while being logged out.
Correct me if I misunderstood, as per issue #27 , we should be able to add item to cart when user is not logged-in. User need to log-in before check out. On this functionality I have worked on.
Correct me if I misunderstood, as per issue https://github.com/dotnet/eShop/issues/27 , we should be able to add item to cart when user is not logged-in. User need to log-in before check out. On this functionality I have worked on.
Thanks for sharing the recording. For whatever reason, I don't see the same behavior when I repro locally. The "Checkout" button doesn't redirect to the login page...
Correct me if I misunderstood, as per issue #27 , we should be able to add item to cart when user is not logged-in. User need to log-in before check out. On this functionality I have worked on.
Thanks for sharing the recording. For whatever reason, I don't see the same behavior when I repro locally. The "Checkout" button doesn't redirect to the login page...
I am not sure, can you ask anyone else to try this?
Correct me if I misunderstood, as per issue #27 , we should be able to add item to cart when user is not logged-in. User need to log-in before check out. On this functionality I have worked on.
Thanks for sharing the recording. For whatever reason, I don't see the same behavior when I repro locally. The "Checkout" button doesn't redirect to the login page...
I am not sure, can you ask anyone else to try this?
Take recent code changes, I have made commits after our last comments!! @captainsafia
@captainsafia I am waiting for PR review again🥺🥺, is there any luck with running it locally?
@jamesmontemagno @adityamandaleeka Looks like you also work on this repo, can you review this if @captainsafia is no more looking in this PR.
Just wanted to know till when I can expect review again? I'm so excited to continue contribution on this!
Hii @captainsafia , will you gonna see this PR again? It's been long time now
@ks1990cn Thanks for your eagerness here, Tanmay! At the moment, we're trying to prioritize bug fixes and quality improvements on eShop before taking new features so we'd like to hold off on merging this change at the moment.
@captainsafia any update on this pr? this feature is very much needed for my scenario.
@cwash05 As @captainsafia mentioned above, we're prioritizing quality/fixes in this project for now so we are holding off on adding functionality.
It's not clear what you mean by this being needed for your scenario. This PR has no impact on the product capabilities of ASP.NET Core, Aspire, or any other technology we ship; this repo/project is merely a sample.
