dotnet icon indicating copy to clipboard operation
dotnet copied to clipboard
verified publisher icon dotnet

[main] Source code updates from dotnet/diagnostics

Open dotnet-maestro[bot] opened this issue 6 months ago • 21 comments

[!NOTE] This is a codeflow update. It may contain both source code changes from the source repo as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/diagnostics

Diff the source with this PR branch 
darc vmr diff --name-only https://github.com/dotnet/diagnostics:6efc8933adc9cfe1dc0338ad1a52643aa51e6580..https://github.com/dotnet/dotnet:darc-main-fa04aa06-fe55-484a-a2f6-a3560c82ec03

dotnet-maestro[bot] avatar Oct 31 '25 02:10 dotnet-maestro[bot]

[!NOTE] PRs from original repository included in this codeflow update:

  • https://github.com/dotnet/diagnostics/pull/5627
  • https://github.com/dotnet/diagnostics/pull/5624
  • https://github.com/dotnet/diagnostics/pull/5616
  • https://github.com/dotnet/diagnostics/pull/5620
  • https://github.com/dotnet/diagnostics/pull/5619
  • https://github.com/dotnet/diagnostics/pull/5618

💡 You may consult the FAQ for more information or tag @dotnet/product-construction for assistance.

dotnet-maestro[bot] avatar Oct 31 '25 02:10 dotnet-maestro[bot]

[!NOTE] PRs from original repository included in this codeflow update:

  • https://github.com/dotnet/diagnostics/pull/5623
  • https://github.com/dotnet/diagnostics/pull/5626

💡 You may consult the FAQ for more information or tag @dotnet/product-construction for assistance.

dotnet-maestro[bot] avatar Nov 01 '25 02:11 dotnet-maestro[bot]

[!NOTE] PRs from original repository included in this codeflow update:

  • https://github.com/dotnet/diagnostics/pull/5631

💡 You may consult the FAQ for more information or tag @dotnet/product-construction for assistance.

dotnet-maestro[bot] avatar Nov 06 '25 02:11 dotnet-maestro[bot]

[!NOTE] PRs from original repository included in this codeflow update:

  • https://github.com/dotnet/diagnostics/pull/5622
  • https://github.com/dotnet/diagnostics/pull/5633
  • https://github.com/dotnet/diagnostics/pull/5634

💡 You may consult the FAQ for more information or tag @dotnet/product-construction for assistance.

dotnet-maestro[bot] avatar Nov 07 '25 02:11 dotnet-maestro[bot]

[!NOTE] PRs from original repository included in this codeflow update:

  • Fix and enforce CFS violations (#5638) (https://github.com/dotnet/diagnostics/pull/5638)
  • [main] Update dependencies from dotnet/dotnet (#5599) (https://github.com/dotnet/diagnostics/pull/5599)
  • [main] Update parameters for manifest paths (#5635) (https://github.com/dotnet/diagnostics/pull/5635)

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

dotnet-maestro[bot] avatar Nov 09 '25 02:11 dotnet-maestro[bot]

[!NOTE] PRs from original repository included in this codeflow update:

  • https://github.com/dotnet/diagnostics/pull/5643
  • https://github.com/dotnet/diagnostics/pull/5642

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

dotnet-maestro[bot] avatar Nov 23 '25 02:11 dotnet-maestro[bot]

[!NOTE] PRs from original repository included in this codeflow update:

  • https://github.com/dotnet/diagnostics/pull/5641

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

dotnet-maestro[bot] avatar Nov 25 '25 02:11 dotnet-maestro[bot]

[!NOTE] PRs from original repository included in this codeflow update:

  • https://github.com/dotnet/diagnostics/pull/5647

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

dotnet-maestro[bot] avatar Nov 29 '25 02:11 dotnet-maestro[bot]

[!NOTE] PRs from original repository included in this codeflow update:

  • https://github.com/dotnet/diagnostics/pull/5640

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

dotnet-maestro[bot] avatar Dec 03 '25 02:12 dotnet-maestro[bot]

[!NOTE] PRs from original repository included in this codeflow update:

  • https://github.com/dotnet/diagnostics/pull/5648

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

dotnet-maestro[bot] avatar Dec 04 '25 02:12 dotnet-maestro[bot]

[!NOTE] PRs from original repository included in this codeflow update:

  • https://github.com/dotnet/diagnostics/pull/5651
  • https://github.com/dotnet/diagnostics/pull/5586

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

dotnet-maestro[bot] avatar Dec 05 '25 02:12 dotnet-maestro[bot]

[!NOTE] PRs from original repository included in this codeflow update:

  • https://github.com/dotnet/diagnostics/pull/5655
  • https://github.com/dotnet/diagnostics/pull/5652
  • https://github.com/dotnet/diagnostics/pull/5579
  • https://github.com/dotnet/diagnostics/pull/5653
  • https://github.com/dotnet/diagnostics/pull/5650
  • https://github.com/dotnet/diagnostics/pull/5614

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

dotnet-maestro[bot] avatar Dec 06 '25 02:12 dotnet-maestro[bot]

[!NOTE] PRs from original repository included in this codeflow update:

  • https://github.com/dotnet/diagnostics/pull/5658

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

dotnet-maestro[bot] avatar Dec 10 '25 02:12 dotnet-maestro[bot]

[!NOTE] PRs from original repository included in this codeflow update:

  • https://github.com/dotnet/diagnostics/pull/5637
  • https://github.com/dotnet/diagnostics/pull/5657

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

dotnet-maestro[bot] avatar Dec 13 '25 02:12 dotnet-maestro[bot]

[!NOTE] PRs from original repository included in this codeflow update:

  • https://github.com/dotnet/diagnostics/pull/5667
  • https://github.com/dotnet/diagnostics/pull/5660

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

dotnet-maestro[bot] avatar Dec 16 '25 02:12 dotnet-maestro[bot]

@hoyosjs @nohwnd new prebuilds:

eng/finish-source-only.proj(136,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) 2 new packages used not in baseline! See report at /__w/1/s/artifacts/log/Release/baseline-comparison.xml for more information. Package IDs are: Microsoft.Extensions.DependencyInjection.Abstractions.8.0.2 Microsoft.Extensions.Logging.Abstractions.8.0.3

eng/finish-source-only.proj(136,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) 4 forbidden test usages found in 2 projects: artifacts/obj/vstest/project-assets-json/obj/Microsoft.TestPlatform.CLI/project.assets.json artifacts/obj/vstest/project-assets-json/obj/Microsoft.TestPlatform.Extensions.BlameDataCollector/project.assets.json

cc @dotnet/source-build

ViktorHofer avatar Dec 18 '25 07:12 ViktorHofer

The offending packages are both dependencies of Microsoft.Diagnostics.NETCore.Client that we use in blame collector. These updates are coming from dotnet/dotnet. And it was only dotnet/dotnet that updated the package in vstest for the past months.

https://github.com/microsoft/vstest/commit/0e2b9718a21a68df812e7c1d58cf1695146111eb

So I am not sure what we are doing wrong to get flagged, or how to fix. Do you have some suggestions?

image

nohwnd avatar Dec 18 '25 10:12 nohwnd

I hope the source-build team can help you here.

ViktorHofer avatar Dec 18 '25 12:12 ViktorHofer

The Microsoft.Extensions.Logging.Abstractions reference in Microsoft.Diagnostics.NETCore.Client.csproj references MicrosoftExtensionsLoggingAbstractionsVersion. The Versions.props flowing in here is downgrading MicrosoftExtensionsLoggingAbstractionsVersion to 8.0.3 from 9.0.8. The 9.0.8 version is defined in SBRP which is where the version was previously coming from in source-build. You have a few options to address this.

  1. Was the downgrade intentional? If reverted back to 9.0.8 this would not be a problem.
  2. Can this be a live version? If you declare this dependency in Version.Detail.xml, source-build would use the latest/live version.
  3. If 8.0.3 is the most desirable option, then it needs to be added to SBRP. See instructions for adding new packages

MichaelSimons avatar Dec 18 '25 14:12 MichaelSimons

[!NOTE] PRs from original repository included in this codeflow update:

  • https://github.com/dotnet/diagnostics/pull/5672

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

dotnet-maestro[bot] avatar Dec 24 '25 02:12 dotnet-maestro[bot]

[!NOTE] PRs from original repository included in this codeflow update:

  • https://github.com/dotnet/diagnostics/pull/5674

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

dotnet-maestro[bot] avatar Jan 04 '26 02:01 dotnet-maestro[bot]

[!NOTE] PRs from original repository included in this codeflow update:

  • https://github.com/dotnet/diagnostics/pull/5594
  • https://github.com/dotnet/diagnostics/pull/5680

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

dotnet-maestro[bot] avatar Jan 20 '26 02:01 dotnet-maestro[bot]

[!NOTE] PRs from original repository included in this codeflow update:

  • https://github.com/dotnet/diagnostics/pull/5682

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

dotnet-maestro[bot] avatar Jan 21 '26 02:01 dotnet-maestro[bot]

[!NOTE] PRs from original repository included in this codeflow update:

  • https://github.com/dotnet/diagnostics/pull/5686
  • https://github.com/dotnet/diagnostics/pull/5677

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

dotnet-maestro[bot] avatar Jan 23 '26 02:01 dotnet-maestro[bot]