dotnet-docker icon indicating copy to clipboard operation
dotnet-docker copied to clipboard

Revert Port environment variable workaround in Aspire Dashboard images

Open lbussell opened this issue 1 year ago • 3 comments

Original issue: https://github.com/dotnet/dotnet-docker/issues/5164

The Aspire Dashboard Dockerfiles currently contain a workaround for a port environment variable issue with the Aspire Dashboard:

https://github.com/dotnet/dotnet-docker/blob/02e6fbd795bb2637042de91092a1194f52ca825c/src/aspire-dashboard/8.0/cbl-mariner-distroless/amd64/Dockerfile#L31-L32

I did not find a tracking issue for this on the Aspire repo but presumably it will be fixed eventually. We want all port/URL environment variables to have the shorthand format:

https://github.com/dotnet/dotnet-docker/blob/32c6a5c755ac3316ca552a55b5a8d5bc927c2d66/src/runtime-deps/6.0/alpine3.18/amd64/Dockerfile#L5

lbussell avatar Feb 12 '24 17:02 lbussell

[Triage] @joperezr, can you make this change when the correct fix is in Aspire? I didn't find a tracking issue for it.

lbussell avatar Feb 15 '24 19:02 lbussell

Yup, will do.

joperezr avatar Feb 16 '24 19:02 joperezr

@joperezr is this fixed in Aspire Dashboard yet? Please link a tracking issue from the Aspire repo.

lbussell avatar Aug 19 '24 18:08 lbussell