dotnet-docker icon indicating copy to clipboard operation
dotnet-docker copied to clipboard
verified publisher icon dotnet

Not all sample images are built and tested in CI/PR validation

Open lbussell opened this issue 2 years ago • 1 comments

https://github.com/dotnet/dotnet-docker/pull/4534 restructured some of the sample dockerfiles, but left some of them, like Dockerfile.debian unable to build and/or run.

The dotnet-docker-samples pipeline only ends up building images that we publish (defined in manifest.samples.json). There should be some additional PR validation that runs pwsh .\build-and-test.ps1 -Path *samples* -TestCategories sample.

lbussell avatar Apr 05 '23 20:04 lbussell

This was tested in CI at one point. I believe it inadvertently stopped as a result of the changes from https://github.com/dotnet/dotnet-docker/pull/4207.

mthalman avatar Apr 06 '23 14:04 mthalman