dotnet-api-docs icon indicating copy to clipboard operation
dotnet-api-docs copied to clipboard

Catch OperationCanceledException instead of TaskCanceledException

Open gewarren opened this issue 2 years ago • 6 comments

Fast-follow to https://github.com/dotnet/dotnet-api-docs/pull/9362. Users should catch OperationCanceledException instead of TaskCanceledException (see https://github.com/dotnet/dotnet-api-docs/pull/9362#issuecomment-1745109860).

Hide whitespace changes in diff.

gewarren avatar Oct 03 '23 23:10 gewarren

Tagging subscribers to this area: @dotnet/ncl See info in area-owners.md if you want to be subscribed.

Issue Details

Fast-follow to https://github.com/dotnet/dotnet-api-docs/pull/9362. Users should catch OperationCanceledException instead of TaskCanceledException (see https://github.com/dotnet/dotnet-api-docs/pull/9362#issuecomment-1745109860).

Hide whitespace changes in diff.

Author: gewarren
Assignees: gewarren
Labels:

area-System.Net.Http

Milestone: -

ghost avatar Oct 03 '23 23:10 ghost

Learn Build status updates of commit 23f21b0:

:warning: Validation status: warnings

File Status Preview URL Details
xml/System.Net.Http/HttpClient.xml :warning:Warning View Details
xml/System.Net.Http/HttpClientHandler.xml :warning:Warning View Details
xml/System.Net.Security/NegotiateStream.xml :white_check_mark:Succeeded View

xml/System.Net.Http/HttpClient.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request. For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Learn Build status updates of commit 3960b0d:

:warning: Validation status: warnings

File Status Preview URL Details
xml/System.Net.Http/HttpClient.xml :warning:Warning View Details
xml/System.Net.Http/HttpClientHandler.xml :warning:Warning View Details
xml/System.Net.Security/NegotiateStream.xml :white_check_mark:Succeeded View

xml/System.Net.Http/HttpClient.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Threading.Tasks.OperationCanceledException'.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request. For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Learn Build status updates of commit 89be5de:

:white_check_mark: Validation status: passed

File Status Preview URL Details
xml/System.Net.Http/HttpClient.xml :white_check_mark:Succeeded View
xml/System.Net.Http/HttpClientHandler.xml :white_check_mark:Succeeded View
xml/System.Net.Security/NegotiateStream.xml :white_check_mark:Succeeded View

For more details, please refer to the build report.

For any questions, please:

Learn Build status updates of commit bc147ff:

:white_check_mark: Validation status: passed

File Status Preview URL Details
xml/System.Net.Http/HttpClient.xml :white_check_mark:Succeeded View
xml/System.Net.Http/HttpClientHandler.xml :white_check_mark:Succeeded View
xml/System.Net.Security/NegotiateStream.xml :white_check_mark:Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren This one has conflicts

adegeo avatar Aug 29 '24 14:08 adegeo