dotnet-api-docs icon indicating copy to clipboard operation
dotnet-api-docs copied to clipboard

Hashset Remove is not throwing on enumeration

Open wrexbe opened this issue 3 years ago • 4 comments

Description

I found some code that was looping over a hashset, and removing items. Hashset is not throwing when you remove while enumerating like it used to. It's convenient that it's like this, but it's different then how it used to work, and I'm not sure if it's safe.

The documentation says it should throw, so either the documentation needs to be updated, or the Hashset needs to be fixed. https://docs.microsoft.com/en-us/dotnet/api/system.collections.generic.hashset-1.getenumerator?view=net-6.0

Reproduction Steps

HashSet<int> set = new();
set.Add(1);
set.Add(2);

foreach (var x in set)
{
    set.Remove(x);
}

Expected behavior

Throws an invalid operation exception

Actual behavior

It works

Regression?

.Net 3.1 throws

Known Workarounds

Don't do it?

Configuration

No response

Other information

No response

wrexbe avatar Jun 25 '22 16:06 wrexbe