dotnet-api-docs icon indicating copy to clipboard operation
dotnet-api-docs copied to clipboard

Fix docs

Open john-h-k opened this issue 4 years ago • 8 comments

They were just wrong before

john-h-k avatar Apr 11 '21 21:04 john-h-k

Docs Build status updates of commit 59f9e72:

:white_check_mark: Validation status: passed

File Status Preview URL Details
xml/System.Runtime.CompilerServices/Unsafe.xml :white_check_mark:Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

opbld32 avatar Apr 11 '21 22:04 opbld32

Why did this PR die?

WhiteBlackGoose avatar Jul 25 '21 18:07 WhiteBlackGoose

@WhiteBlackGoose It looks like the original author didn't accept the change or respond to the feedback.

@gewarren Do you want to accept your suggestions and merge this?

BillWagner avatar Jul 25 '21 21:07 BillWagner

Docs Build status updates of commit 772c395:

:x: Validation status: errors

Please follow instructions here which may help to resolve issue.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

opbld34 avatar Jul 26 '21 19:07 opbld34

Docs Build status updates of commit 772c395:

:x: Validation status: errors

Please follow instructions here which may help to resolve issue.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

opbld34 avatar Jul 26 '21 19:07 opbld34

Docs Build status updates of commit 772c395:

:white_check_mark: Validation status: passed

File Status Preview URL Details
xml/System.Runtime.CompilerServices/Unsafe.xml :white_check_mark:Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

opbld30 avatar Jul 27 '21 04:07 opbld30

This PR conflicted with https://github.com/dotnet/dotnet-api-docs/pull/8097 Is it still needed with changes in that PR?

MSDN-WhiteKnight avatar Jun 30 '22 04:06 MSDN-WhiteKnight

@GrabYourPitchforks Should the As<T> comments be changed to use "reinterpret" instead of "cast" as in this PR?

gewarren avatar Jun 30 '22 15:06 gewarren