Are there any naming rules for primary constructors?

[DmitryLukyanov]

Type of issue

Missing information

Description

I wonder whether any naming rules are considered for primary constructors? public class Entity(Dependency dependency) vs public class Entity(Dependency _dependency) ? (refer to Private instance fields start with an underscore (_) and the remaining text is camelCased.)

Page URL

https://learn.microsoft.com/en-us/dotnet/csharp/fundamentals/coding-style/identifier-names

Content source URL

https://github.com/dotnet/docs/blob/main/docs/csharp/fundamentals/coding-style/identifier-names.md

Document Version Independent Id

7f85babc-6295-21dd-f194-dede663f9966

Article author

@BillWagner

Metadata

• ID: a2d591be-290e-62d1-e99a-a7d26af20ef8
• Service: dotnet-csharp
• Sub-service: fundamentals

[github-actions[bot]]

Hi there @vantovic!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

[NguyenThuyLan]

Hi @vantovic , thanks for reporting this issue. I'm trying to reproduce this issue. Could you please describe in more detail how to trigger a notification? Are you using workflow?

[ghost]

Hi @NguyenThuyLan, in my concrete situation was happening when a user is subscribed to a node and a writer sends a document for approval. The subcribed user does not get the email notification. As I see in v14 it should be resolved, in v13 the line https://github.com/umbraco/Umbraco-CMS/blob/d72fc5c4e83c71dfee73b45fc2eacf5158a040e6/src/Umbraco.Core/Services/NotificationService.cs#L109 should cause the issue later on https://github.com/umbraco/Umbraco-CMS/blob/d72fc5c4e83c71dfee73b45fc2eacf5158a040e6/src/Umbraco.Core/Services/NotificationService.cs#L140

I will try to make a demo project

[AndyButland]

Fixed via https://github.com/umbraco/Umbraco-CMS/pull/18370 for 13.9.