Implicit typing inside a foreach statement

[ghost]

I noticed something in the sample code at https://docs.microsoft.com/en-us/dotnet/csharp/tutorials/intro-to-csharp/list-collection?tutorial-step=1

The example is using the var keyword inside the foreach statement. But the C# coding conventions here claim that implicit typing shouldn't be used for foreach loops.

This means that the following code is wrong

foreach (var name in names)
{
  Console.WriteLine($"Hello {name.ToUpper()}!");
}

and should be replaced with

foreach (string name in names)
{
  Console.WriteLine($"Hello {name.ToUpper()}!");
}

I'm not sure if this is considered an error since it's about coding style, but I thought that perhaps it will be worth pointing out.

---

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

• ID: 67ff1559-a7c6-9c97-e543-298fbf63f57f
• Version Independent ID: ec7a656b-a94e-7d88-5162-32e931f2e094
• Content: Data collections - Introduction to C# interactive tutorial
• Content Source: docs/csharp/tutorials/intro-to-csharp/list-collection.yml
• Product: dotnet-csharp
• GitHub Login: @BillWagner
• Microsoft Alias: wiwagn

[BillWagner]

Thanks for writing this @nathaniades

I've added it to our backlog for the next time we update this article.