docs-aspire icon indicating copy to clipboard operation
docs-aspire copied to clipboard

Module 2: Create a .NET Aspire application

Open CamSoper opened this issue 1 year ago • 11 comments

Staging link

PR: https://github.com/MicrosoftDocs/learn-pr/pull/42327


Associated WorkItem - 215927

CamSoper avatar Feb 23 '24 22:02 CamSoper

@CamSoper and @IEvangelist I've addressed all feedback. Updated yaml and filenames. Can we create an official MS repo for my sample code https://github.com/PhilStollery/aspire-starter?

I tried to fix my PR my updating my branch with updates from main - so have $*@^@@& the PR. Should I delete and create a new PR?

[!NOTE] This content was automatically updated to filter out profanity. If you feel as though this was done in error, please file an issue with the details.

PhilStollery avatar Mar 01 '24 11:03 PhilStollery

I tried to fix my PR my updating my branch with updates from main - so have $*@^@@& the PR. Should I delete and create a new PR?

Sure, that's the easiest way.

Here's a repo for the sample. You and @alistairmatthews should have write access. https://github.com/MicrosoftDocs/mslearn-aspire-starter

LOL @IEvangelist's profanity filter 🤣 @IEvangelist is the fun police! 🚓🚨

CamSoper avatar Mar 01 '24 20:03 CamSoper

https://github.com/MicrosoftDocs/learn-pr/pull/42973, will get to raising a PR for the sample repo and update the content to use it.

PhilStollery avatar Mar 04 '24 17:03 PhilStollery

@PhilStollery Please ping me here when you do, my GitHub inbox is really noisy and I miss PRs sometimes 😄

CamSoper avatar Mar 05 '24 01:03 CamSoper

@CamSoper FYI.

New PR for content: https://github.com/MicrosoftDocs/learn-pr/pull/43741 Code repo: https://github.com/MicrosoftDocs/mslearn-aspire-starter

PhilStollery avatar Mar 26 '24 17:03 PhilStollery

@alistairmatthews this staging link seems broken can you update it with the right one? or hit me here with it?

bradygaster avatar Apr 23 '24 15:04 bradygaster

@alistairmatthews this staging link seems broken can you update it with the right one? or hit me here with it?

@bradygaster - the new staging link is here: Staging link

I don't have permissions to edit the one above. :~(

alistairmatthews avatar Apr 24 '24 16:04 alistairmatthews

Reviewed this one, left a few notes in teams to provide commentary as I'm not sure where to provide commentary in a pull request.

bradygaster avatar Apr 26 '24 23:04 bradygaster

I've updated this module to preview 6. Just small changes and screenshots.

alistairmatthews avatar May 07 '24 16:05 alistairmatthews

I've created a new PR for this: https://github.com/MicrosoftDocs/learn-pr/pull/44681 Staging link Module is ready to merge.

alistairmatthews avatar May 15 '24 16:05 alistairmatthews

This is the latest PR, which fixes two small blockers: https://github.com/MicrosoftDocs/learn-pr/pull/44688 Staging link

alistairmatthews avatar May 15 '24 18:05 alistairmatthews