docker-tools
docker-tools copied to clipboard
This is a repo to house some common tools for our various docker repos.
A workaround was added in https://github.com/dotnet/docker-tools/pull/1173: https://github.com/dotnet/docker-tools/blob/965b56f5131e80746c7dfce99b22785a73f58de2/src/Microsoft.DotNet.ImageBuilder/src/DockerService.cs#L93-L98 According to the Docker release notes, the issue is resolved in Docker Engine version 23: https://github.com/moby/buildkit/issues/1368 This workaround should be removed once our...
The build stage of the pipeline generates SBOMs using this logic: https://github.com/dotnet/docker-tools/blob/9791b1592829efbcd4da15a4aabed083b66615b7/eng/common/templates/jobs/build-images.yml#L128-L176 The use of the ManifestGeneratorTask is only used as an "installer" in order to acquire the manifest tool...
There are various Dockerfile linter tools out there ([hadolint](https://github.com/hadolint/hadolint) comes to mind) that can be used to ensure our Dockerfiles are following best practices. As we continue to evolve our...
The implementation of the `AzureArtifacts.manifest-generator-task.manifest-generator-task.ManifestGeneratorTask` has repeatedly broken our pipelines. See https://github.com/dotnet/docker-tools/pull/990, https://github.com/dotnet/docker-tools/issues/1152, https://github.com/dotnet/docker-tools/pull/1045. We need to protect the pipeline from these breaks since they can occur at any point...
The following error occurs when executing the [SBOM generation step](https://github.com/dotnet/docker-tools/blob/9791b1592829efbcd4da15a4aabed083b66615b7/eng/common/templates/jobs/build-images.yml#L134-L176): ``` ForEach-Object : The term 'D:\a\_work\_tasks\ManifestGeneratorTask_0a569e1c-b731-4e6d-995a-8184fcd1f6e7\0.197.56\dotnet-6.0.15 D:\a\_work\_tasks\ManifestGeneratorTask_0a569e1c-b731-4e6d-995a-8184fcd1f6e7\0.197.57\dotnet-6.0.15/dotnet' is not recognized as the name of a cmdlet, function, script file, or...
I got fooled by my own infra logic. After running a test build, I was expecting the images to be published to our dotnetdocker ACR under a "test" repository but...
When a tag in the manifest is marked as `IsLocal`, it means that tag will not be pushed when running the Build command with the `--push` option. When the CopyAcrImages...
``` WARNING! Your password will be stored unencrypted in /root/.docker/config.json. Configure a credential helper to remove this warning. See https://docs.docker.com/engine/reference/commandline/login/#credentials-store ```
The file pattern matching that is done is based on the string contents of the manifest.json file rather than the physical file system. This requires there to be some non-intuitive...
Please see https://github.com/dotnet/dotnet-docker/issues/4634 for more details. Essentially, ImageBuilder will allow you to have multiple OS types or architectures categorized under the same shared tags, which results in the readmes being...