docker-tools icon indicating copy to clipboard operation
docker-tools copied to clipboard

Remove usages of 1es-official.yml and 1es-unofficial.yml pipeline templates

Open Copilot opened this issue 1 week ago • 2 comments

Migrates all pipelines from deprecated 1es-official.yml and 1es-unofficial.yml templates to the unified 1es.yml template introduced in #1771, and removes the deprecated template files. The new template auto-selects official vs. unofficial based on pipeline name (-official suffix triggers official template).

Changes

Template migration pattern:

  • Before:
    extends:
      template: /eng/docker-tools/templates/1es-official.yml@self
      parameters:
        serviceConnections:
        - name: $(acr.serviceConnectionName)
        stages: [...]
    
  • After:
    extends:
      template: /eng/docker-tools/templates/1es.yml@self
      parameters:
        stages:
        - template: /eng/docker-tools/templates/stages/setup-service-connections.yml@self
          parameters:
            serviceConnections:
            - name: $(acr.serviceConnectionName)
        - [... other stages]
    

Service connections: Moved from template parameter to explicit stage (new template doesn't auto-inject setup stage)

Removed parameters: cgDryRun, disableSDL, serviceConnections (not supported by unified template)

Pipelines updated: 8 official, 2 unofficial (10 total)

Deprecated template files removed:

  • eng/docker-tools/templates/1es-official.yml (70 lines)
  • eng/docker-tools/templates/1es-unofficial.yml (79 lines)

This eliminates 149 lines of duplicated template code and simplifies pipeline maintenance.

Post-merge requirement

Pipeline names in Azure DevOps must contain -official for official pipelines. Verify/rename:

  • Official: cg-detection, check-base-image-updates, mirror-base-images, annotate-eol-digests, upload-file, import-image
  • Unofficial: secret-management-weekly

Pipelines with -official in filename are likely already correct.

Original prompt

This section details on the original issue you should resolve

<issue_title>Remove usages of 1es-official.yml and 1es-unofficial.yml pipeline templates</issue_title> <issue_description>https://github.com/dotnet/docker-tools/pull/1771 added the new 1es.yml template which automatically selects between the 1ES official and unofficial pipeline templates based on the pipeline name. If the pipeline name contains -official, it will use the official template, otherwise it will use the unofficial template.

Using this new template has the benefit of eliminating duplicated configurations between official and unofficial templates. References to the old 1es-official.yml and 1es-unofficial.yml templates should be removed and replaced with the new 1es.yml template. Special care should be taken to ensure the pipelines are properly named in order to select the correct template.</issue_description>

Comments on the Issue (you are @copilot in this section)

  • Fixes dotnet/docker-tools#1892

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot avatar Jan 05 '26 19:01 Copilot