docker-tools icon indicating copy to clipboard operation
docker-tools copied to clipboard

Treat Windows tags more like Linux tags in generated tags tables

Open lbussell opened this issue 10 months ago • 5 comments

Readme generation separates all tags into the following tables:

  1. Linux amd64
  2. Linux arm64
  3. Linux arm32
  4. Nano Server 2025 amd64
  5. Windows Server Core 2025 amd64
  6. Nano Server 2022 amd64
  7. Windows Server Core 2022 amd64
  8. ... and so on for all prior supported Windows versions

I propose that we change this to:

  1. Linux amd64
  2. Linux arm64
  3. Linux arm32
  4. Windows amd64
  5. (Windows arm64)
    • Not supported at the moment but this is where it would go if we had Windows ARM images.

This would cut down on the number of sections in the full tags listing.

lbussell avatar Feb 14 '25 19:02 lbussell

Is there a reason that only Windows Server 2025 is listed in the proposal? I assume the other versions will still be listed after that?

mthalman avatar Feb 18 '25 14:02 mthalman

Is there a reason that only Windows Server 2025 is listed in the proposal? I assume the other versions will still be listed after that?

Sorry, that was a mistake. I edited the issue body. The proposal is to group all Windows tags together per architecture, using the same pattern as the Linux tags.

lbussell avatar Feb 18 '25 16:02 lbussell

It think it would be useful to provide some history and what has changed in this area...

Prior to .NET 8.0, Windows containers were included in the multi-platform tags (see announcement for more details). With multi-platform tags and showing multiple windows versions within a single tags table, there was confusion caused by a specific tag appearing multiple times within a single tags table. Working with folks from MAR, an agreement was reached that is would be best to split the Windows tags apart by version. There were some other benefits of splitting the images by windows version related to the compatibility limitations.

With Windows Containers being removed from the multi-platform tags, the tag confusion problem that drove this design is eliminated. We should add the OS Version column to the new combined Windows table.

MichaelSimons avatar Feb 18 '25 16:02 MichaelSimons

With Windows Containers being removed from the multi-platform tags, the tag confusion problem that drove this design is eliminated. We should add the OS Version column to the new combined Windows table.

Note that this does not apply to https://github.com/microsoft/dotnet-framework-docker where we still do have multi-platform tags for Windows.

mthalman avatar Feb 18 '25 16:02 mthalman

Note that this does not apply to https://github.com/microsoft/dotnet-framework-docker where we still do have multi-platform tags for Windows.

So this would need an extra option to enable the old behavior for Windows?

lbussell avatar Feb 18 '25 17:02 lbussell