docker-tools icon indicating copy to clipboard operation
docker-tools copied to clipboard

Use pipeline variable to reference MAR Status API resource/scope

Open lbussell opened this issue 1 year ago • 3 comments

Currently we hardcode the resource scope for the MAR status API: https://github.com/dotnet/docker-tools/blob/7b8f03267f6687fd6ecf7bca1071f74536c1cfa6/src/Microsoft.DotNet.ImageBuilder/src/McrStatusClient.cs#L20

This is very inflexible and requires changes to our source code if we need to change where this points to. Instead, we should accept a scope via the CLI and pass it in via an environment variable so that we can change it as needed without rebuilding ImageBuilder. We don't intend to frequently access this API on dev machines, so this should be an acceptable solution.

lbussell avatar May 15 '24 18:05 lbussell

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

ghost avatar May 15 '24 18:05 ghost

It would probably make sense to define this in our Dotnet-Docker-Common variable group.

mthalman avatar May 15 '24 18:05 mthalman

There is a WIP branch for this here - https://github.com/lbussell/docker-tools/tree/issue-1288

lbussell avatar Aug 30 '24 17:08 lbussell