dnceng icon indicating copy to clipboard operation
dnceng copied to clipboard
verified publisher icon dotnet

Update helix-machines to use `Microsoft.ImageFactory.SDK`

Open dougbu opened this issue 1 year ago • 4 comments

Following the work done in #2018 and #2374, we still have custom code in dotnet-helix-machines for interaction with Image Factory. This code mostly duplicates what the Image Factory team now provides in the Microsoft.ImageFactory.SDK package. Updating to use their code will reduce duplication of effort, avoid maintenance costs on our side, and generally help us avoid being a unicorn going forward.

Release Note Category

  • [ ] Feature changes/additions
  • [ ] Bug fixes
  • [x] Internal Infrastructure Improvements

Release Note Description

Adopted use of the Microsoft.ImageFactory.SDK when interacting with Image Factory in the dotnet-helix-machines code.

Important

Subsequently and hopefully-temporarily scaled back to cover only our custom (not base) image generations

dougbu avatar Mar 26 '24 21:03 dougbu

needs another fix due to a typo. please see that in !49764

dougbu avatar May 05 '25 23:05 dougbu

rolled out

dougbu avatar May 12 '25 02:05 dougbu

reopening due to dotnet-helix-machines-image-generation failures. though submissions are fine, builds fail with poorly-understood errors:

  Failed to get value for secret { "ValueKind": "String" }: Invalid URI: The URI scheme is not valid. This could be an access issue or a URL 
  format issue (see error above for more details).

there's no additional information earlier but it seems like there's a problem w/ the KVSecret_AppSecret to the 1ES prerequisites artifacts

  2025-05-07 08:23:34Z -> N:\scripts\DefaultArtifactSource\artifacts\Windows-VisualStudio-Bootstrapper\Windows-VisualStudio-Bootstrapper.ps1 : 
  Cannot process argument transformation on parameter 'VSDropAuthorizationRequired'. Cannot convert value 
"System.String" to type "System.Boolean". Boolean parameters accept only Boolean values and numbers, such as $True, 
$False, 1 or 0.
  At N:\Windows-VisualStudio-Bootstrapper_ef6f4f23-3a46-46d6-977e-04a24a083c4e.ps1:9 char:4
  +   "ValueKind": "String"
  +    ~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidData: (:) [Windows-VisualStudio-Bootstrapper.ps1], ParentContainsErrorRecordExcep 
   tion
    + FullyQualifiedErrorId : ParameterArgumentTransformationError,Windows-VisualStudio-Bootstrapper.ps1

we don't include a VSDropAuthorizationRequired parameter when using the Windows-VisualStudio-Bootstrapper artifact

dougbu avatar May 12 '25 19:05 dougbu

revert in !49994. updated release notes for a mention in our next rollout

dougbu avatar May 12 '25 23:05 dougbu