deployment-tools icon indicating copy to clipboard operation
deployment-tools copied to clipboard

Published 20 hours ago • verified publisher icon dotnet

Include @dotnet/source-build-internal as code owners for SB files

Open ellahathaway opened this issue 1 year ago • 2 comments

@dotnet/source-build-internal is not tagged as a code owner for SourceBuildPrebuiltBaseline.xml. It would be helpful to create a CODEOWNERS file and include source-build-internal on SB files. For reference, Aspnet does this in their CODEOWNERS file: https://github.com/dotnet/aspnetcore/blob/36c976723fd0b55dad80f1ff32e665800ea4a021/.github/CODEOWNERS#L19

Having a code owners file would also be generally useful when opening PRs in this repo, as it can sometimes be difficult and time consuming to determine who should be included as a reviewer.

ellahathaway avatar Dec 08 '23 18:12 ellahathaway

Related issue: https://github.com/dotnet/arcade/issues/9555

lbussell avatar Dec 08 '23 19:12 lbussell

[Triage] Approved - please fix.

NikolaMilosavljevic avatar Jan 16 '24 22:01 NikolaMilosavljevic