corefx icon indicating copy to clipboard operation
corefx copied to clipboard

[release/3.1] Fix build clang10

Open ayakael opened this issue 3 years ago • 8 comments

Fixes build with clang 10+. I'm not sure how this affects previous versions of clang, I havn't had the opportunity to test.

Made as part of Alpine Linux dotnet31 / dotnet5 packaging project, see dotnet/source-build#2695

ayakael avatar Dec 17 '21 02:12 ayakael

@omajid This bug is also in Fedora's 3.1 package. Is there a reason you did not upstream? I see if breaks checks in Windows / MacOS build, thus I want to see if its worth keeping open.

ayakael avatar Jan 14 '22 15:01 ayakael

I think it's a good idea to keep corefx (and coreclr) building with newer clang versions. I have a PR in progress for clang 13 support as well. But we can't break Windows or macOS. Perhaps we can check that the compiler supports the flags before enabling them?

omajid avatar Jan 14 '22 17:01 omajid

Referencing your PR, I've introduced the checks. Thanks!

ayakael avatar Jan 21 '22 18:01 ayakael

@ayakael should this PR be closed, since we have this other one? https://github.com/dotnet/corefx/pull/43104

carlossanlop avatar Apr 05 '22 22:04 carlossanlop

@hoyosjs is this something you could help review?

carlossanlop avatar Sep 07 '22 20:09 carlossanlop

/azp run corefx-ci

hoyosjs avatar Sep 07 '22 23:09 hoyosjs

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 07 '22 23:09 azure-pipelines[bot]

Don't see how, but there's a fair amount of failures here.

hoyosjs avatar Sep 13 '22 22:09 hoyosjs

Closing since 3.1 is going out of support.

carlossanlop avatar Nov 18 '22 01:11 carlossanlop