core icon indicating copy to clipboard operation
core copied to clipboard

Api-diff between 7.0-preview7 and 7.0-rc1

Open carlossanlop opened this issue 3 years ago • 3 comments

If you see unusual diffs in this PR, please help fixing them via suggestions. I would greatly appreciate it.

ASP.NET: https://github.com/orgs/dotnet/teams/aspnet-api-review WinForms: @merriemcgaw @RussKie @JeremyKuhne WPF: @singhashish-wpf and @pchaurasia14 Libraries: @danmoseley @jeffhandley @karelz @ericstj @stephentoub

@dotnet/area-microsoft-win32 @dotnet/area-system-buffers @dotnet/area-system-componentmodel System.Data @ajcvickers @davoudeshtehari @david-engel System.Diagnostics @tommcdon @dotnet/area-system-formats-asn1 @dotnet/area-system-io @dotnet/area-system-linq System @dotnet/area-system-runtime System.Net* @dotnet/ncl @dotnet/area-system-numerics @dotnet/area-system-reflection-emit @dotnet/area-system-reflection System.Runtime.InteropServices @dotnet/interop-contrib @dotnet/area-system-runtime System.Runtime.Serialization @HongGit @StephenMolloy System.Runtime.Versioning @buyaa-n

carlossanlop avatar Sep 15 '22 19:09 carlossanlop

@KlausLoeffelmann can you sanity check the WinForms changes you made here? Thanks!

JeremyKuhne avatar Sep 15 '22 20:09 JeremyKuhne

System.Runtime.Versioning, System.Reflection, System.Reflection.Emit changes LGTM

buyaa-n avatar Sep 20 '22 21:09 buyaa-n

The content of System.Security.* and System.Formats.Asn1 looks correct to me; but the attribute-only changes are showing as very noisy diffs, suggesting we removed a lot of methods. Those diffs really need to be cleaned up.

bartonjs avatar Sep 20 '22 22:09 bartonjs

@bartonjs I can apply your suggestions for APIs that only had their attributes changed, but note that this is something that affects many APIs and has been happening with AsmDiff for a long time. I really don't think this is worthy of this much attention and the priority seems low.

carlossanlop avatar Sep 22 '22 19:09 carlossanlop