Handle left Token being null in == and !=.

Open andrewimcclement opened this issue 3 years ago • 1 comments

Fixes #1797. This seems the simplest change to get things working correctly.

Marking as sealed is important to avoid potential complications with derived classes.

Personally I find it fairly natural to have == and != defined for something implementing IEquatable<T> - it provides a natural way to check for equality including nulls.

Jul 19 '22 16:07 andrewimcclement

This is no longer needed because https://github.com/dotnet/command-line-api/issues/1797 was fixed by https://github.com/dotnet/command-line-api/pull/1842.

Sep 09 '22 16:09 KalleOlaviNiemitalo

Thanks, @andrewimcclement. The bug was fixed elsewhere. Sealing Token is a reasonable thing to do. If you'd like to resubmit that change, I'd be happy to merge it.

Oct 17 '22 16:10 jonsequitur