command-line-api icon indicating copy to clipboard operation
command-line-api copied to clipboard
verified publisher icon dotnet

When missing add name of argument for command to error message

Open zpittmansf opened this issue 5 years ago • 3 comments

Instead of "Required argument missing for command: {commandname}", provide "Required argument {argumentname} missing for command: {commandname}" for better clarity as to which required argument is missing.

https://github.com/dotnet/command-line-api/blob/a5217048b1a1e93082cbcbcf48479ee8b565ab2a/src/System.CommandLine/ValidationMessages.cs#L53

zpittmansf avatar Nov 09 '20 18:11 zpittmansf

@Drizin appears to have a proof of concept 49371bc. What additional changes or review is needed?

From reviewing: CONTRIBUTING.md

  • [ ] A minimal reproduction - Is this required in this instance?
  • [ ] Unit Tests
  • [ ] Breaking Changes? (This doesn't appear to be, I haven't dug in to confirm with testing)

Forge36 avatar Dec 13 '22 14:12 Forge36

@Forge36 thanks for bringing this. I've just submitted PR 1993 with that improvement.

Drizin avatar Dec 13 '22 15:12 Drizin

Any news on this issue? Seems the PR has been open a while now

TMUNYU avatar Oct 27 '23 14:10 TMUNYU