codeformatter icon indicating copy to clipboard operation
codeformatter copied to clipboard

Still in use / relevant?

Open kierenj opened this issue 8 years ago • 10 comments

Hi - just checking if this project is a good one to adopt for projects moving forward? Is there a roadmap for .NET Core support, etc? Thanks!

kierenj avatar Aug 09 '17 17:08 kierenj

Seconded.

Ippo343 avatar Aug 21 '17 13:08 Ippo343

It appears the answer to that question is a clear 👎

aweiker avatar Sep 20 '17 04:09 aweiker

  1. last commit was on Nov 11, 2016
  2. no response to an is it dead question
  3. and the funny part https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md: "We also use the .NET Codeformatter Tool to ensure the code base maintains a consistent style over time, the tool automatically fixes the code base to conform to the guidelines outlined above."

schweinsbauch avatar Sep 21 '17 12:09 schweinsbauch

Well, that's fair enough, things move on. But, just in case it makes a difference, I hope those involved won't mind me tagging the last 3 committers to verify I should find another approach? - @jaredpar @alexsorokoletov @davkean

kierenj avatar Sep 21 '17 14:09 kierenj

@kierenj indeed, I did not get any notifications on that project. I guess Jared will have clearer picture. In my understanding, this approach (using Roslyn) is the most correct and straightforward. You can compile it against .NET/Mono and use the output.

I worked in a separate branch to run that thing using .NET Core but many dependencies are not yet there and there is some work to get them in.

I guess this project is alive in a way that you can use it. Lack of development is probably because recent .NET Standard 2 release.

alexsorokoletov avatar Sep 21 '17 17:09 alexsorokoletov

@karelz also.

danmoseley avatar Sep 21 '17 18:09 danmoseley

This isn't a supported tool or product. It was a "hey we have a bunch of code that we are opening sourcing that has different code styles - let's fix that". Along the road we made changes as we open sourced more code. As we've stopped porting code - we stopped needing it as much.

We wrote it to scratch an itch - that itch has been scratched, so no focus on it anymore.

davkean avatar Sep 22 '17 00:09 davkean

@davkean First of all, thank you for sharing this code and "product". I'm grateful we have it (and assume many of people who contributed to issues and PRs).

What we need to understand is the future of this repo/code/tool. There is a number of PRs ready to be merged and many good (as far as I can see).

Do we fork that repo and go there and contribute in a new place? Wondering what are your thoughts.

Thank you

alexsorokoletov avatar Sep 23 '17 06:09 alexsorokoletov

FWIW, I wrote a 30-line powershell function that will convert a VS 2017 .csproj (including .NET core .csprojs) to a primitive VS 2015 .csproj, so codeformatter can still format my code. It's a hack and a half, but it works for my purposes. It's here: https://github.com/GoogleCloudPlatform/dotnet-docs-samples/blob/442e0ef50e58acc5e0414cef31801e394b932724/BuildTools.psm1#L460

SurferJeffAtGoogle avatar Oct 24 '17 18:10 SurferJeffAtGoogle

When I was looking for an automatic C# style formatter, my used search engine showed up this project quite at the top. I am glad I looked further: dotnet-format is probably the tool you should use today.

sbeyer avatar Jun 13 '19 00:06 sbeyer