Diagnostic logging fixes

Open danquirk opened this issue 9 years ago • 0 comments

SARIF logs were being incorrectly generated since each error class (syntactic/semantic/etc) was calling LogDiagnostics upon completion. Now all Diagnostics are aggregated together at the end of analysis and then logged, producing a proper JSON output.

I'd merged the 1.3 Roslyn upgrade branch (PR here https://github.com/dotnet/codeformatter/pull/237) from my machine in here to make sure these changes still worked with the new SARIF format. I recommend just browsing the .cs changes or going commit by commit and just looking at the first 2 commits.

Jun 16 '16 02:06 danquirk